Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: License of Event Data & Content clear field #4980

Merged
merged 2 commits into from
Sep 4, 2020
Merged

fix: License of Event Data & Content clear field #4980

merged 2 commits into from
Sep 4, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #2302 (completing remaining part of wizard step 2 of licence )

captured (1)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ozygp6il0
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-12.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

there is no option like power select allowClear in case of UIDropDown

@snitin315
Copy link
Member

I think there was a clearable named property for dropdown in Semantic-UI.

@iamareebjamal
Copy link
Member

That won't work here AFAIK as this is not a property of event but event.copyright.license

@iamareebjamal
Copy link
Member

@maze-runnar Try using Power Select for this as well

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #4980 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4980      +/-   ##
===============================================
- Coverage        22.68%   22.68%   -0.01%     
===============================================
  Files              485      485              
  Lines             5153     5154       +1     
  Branches            21       21              
===============================================
  Hits              1169     1169              
- Misses            3980     3981       +1     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/forms/wizard/other-details-step.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 326e576...cbe2954. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 4, 2020

@iamareebjamal i have added powerselect -

<PowerSelect
      @selected={{this.data.event.copyright.licence}}
      @allowClear={{true}}
      @options={{this.licenses}}
      @placeholder={{t 'Select Licence'}}
      @onChange={{fn (mut this.data.event.copyright.licence)}} as |licence|>
        {{licence.name}}
    </PowerSelect>

SHowing all fields correctly -
Screenshot from 2020-09-04 15-54-07

But it is showing [Object object ] on event page.
Screenshot from 2020-09-04 15-51-35

@iamareebjamal
Copy link
Member

The JS object was assigned instead of name

@maze-runnar
Copy link
Contributor Author

The JS object was assigned instead of name

<PowerSelect
      @selected={{this.data.event.copyright.licence.name}}
      @allowClear={{true}}
      @options={{this.licenses}}
      @placeholder={{t 'Select Licence'}}
      @onChange={{fn (mut this.data.event.copyright.licence.name)}} as |licence|>
        {{licence}}
    </PowerSelect>

tried this too, not worked

@iamareebjamal iamareebjamal merged commit b546088 into fossasia:development Sep 4, 2020
@maze-runnar maze-runnar deleted the patch-12 branch September 4, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Type,Event Topic,Event subtopic, License cannot be made null once set
3 participants