Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add refund policy section in other-details step #5029

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 9, 2020

Fixes #4957

Requires fossasia/open-event-server#7253

Changes proposed in this pull request:

Screenshot at 2020-09-09 20-54-11
Screenshot at 2020-09-09 20-50-17

@vercel
Copy link

vercel bot commented Sep 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3vn3ij0z3
✅ Preview: https://open-event-frontend-git-fork-snitin315-feat-refund-policy.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #5029 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5029      +/-   ##
===============================================
+ Coverage        22.69%   22.74%   +0.05%     
===============================================
  Files              485      485              
  Lines             5165     5165              
  Branches            21       21              
===============================================
+ Hits              1172     1175       +3     
+ Misses            3989     3986       -3     
  Partials             4        4              
Impacted Files Coverage Δ
app/models/event.js 53.84% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18a5c4...1b2419a. Read the comment docs.

@snitin315 snitin315 changed the title [WIP] feat: add refund policy section in other-details step feat: add refund policy section in other-details step Sep 9, 2020
@auto-label auto-label bot added the feature label Sep 9, 2020
@mariobehling
Copy link
Member

Looks good. Thanks.

We need to think how to display that if the text is longer. Let's consider this later and let's move forward. Cheers!

@iamareebjamal iamareebjamal merged commit 0535897 into fossasia:development Sep 9, 2020
@mariobehling
Copy link
Member

Ok, I missed that the refund box is pre-filled. It should not be pre-filled. Please see details here #5036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 2: Implement a Refund Text Box and add info on public event page
3 participants