Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ability to remove admin area social links #5038

Merged
merged 4 commits into from
Sep 10, 2020
Merged

fix: ability to remove admin area social links #5038

merged 4 commits into from
Sep 10, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 10, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Sep 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bs5wxi8gm
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-links.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 10, 2020
@iamareebjamal
Copy link
Member

Did this happen due to a typo or something else?

@iamareebjamal
Copy link
Member

I'm still not able to delete the links. Please check again. I need to be able to delete all the characters from the input field and it should nullify the bounded property.

So, for example if from [https://facebook.com/]eventyay eventyay is removed, meaning now the field is empty, then facebookUrl should be set to null

snitin315
snitin315 commented Sep 10, 2020
View reviewed changes
app/components/widgets/forms/link-input.js
Comment on lines 33 to 34
protocolAddressObserver() {
if (!this.address) {return}
const link = this.linkName?.toLowerCase();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not letting us delete the whole eventyay, even in UI we removed eventyay but e was still not removed behind the scenes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please ensure this isn't happening - #4947

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Screenshot at 2020-09-10 19-13-08

app/utils/computed-helpers.js Outdated Show resolved Hide resolved
@snitin315
Copy link
Member Author

admin

@codecov
Copy link

codecov bot commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #5038 into development will increase coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5038      +/-   ##
===============================================
+ Coverage        22.68%   22.74%   +0.05%     
===============================================
  Files              488      488              
  Lines             5183     5183              
  Branches            21       21              
===============================================
+ Hits              1176     1179       +3     
+ Misses            4003     4000       -3     
  Partials             4        4
Impacted Files Coverage Δ
app/components/widgets/forms/link-input.js 33.33% <ø> (+1.19%) ⬆️
app/models/social-link.js 0.00% <ø> (ø)
app/utils/computed-helpers.js 21.27% <33.33%> (-0.47%) ⬇️
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3275795...15adda4. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview September 10, 2020 12:35 Inactive
@snitin315 snitin315 changed the title fix: ability to remove admin area social links [WIP]fix: ability to remove admin area social links Sep 10, 2020
@auto-label auto-label bot removed the fix label Sep 10, 2020
@snitin315 snitin315 changed the title [WIP]fix: ability to remove admin area social links fix: ability to remove admin area social links Sep 10, 2020
@auto-label auto-label bot added the fix label Sep 10, 2020
@snitin315 snitin315 mentioned this pull request Sep 10, 2020
Closed
@snitin315
Copy link
Member Author

@iamareebjamal please take a look

@iamareebjamal
Copy link
Member

Looks good but there is one issue. The prefix remains to be https:// for a predefined link until I start typing in the field. For example, for instagram it will be https:// but when I start typing it becomes https://instagram.com/

It should be https://instagram.com/ since the beginning. But since we are already behind schedule, this can be added later

@iamareebjamal iamareebjamal mentioned this pull request Sep 10, 2020
Closed
@iamareebjamal iamareebjamal merged commit 2b18748 into fossasia:development Sep 10, 2020
@snitin315 snitin315 deleted the fix/links branch September 21, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Social System Links functionality URL and Form bugs after Recent Changes in Admin Section
2 participants
@snitin315 @iamareebjamal