Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore map hide toggle behaviour #5044

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 10, 2020

Fixes #5043

@vercel
Copy link

vercel bot commented Sep 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d4ekx2335
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-map-hide.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #5044 into development will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5044   +/-   ##
============================================
  Coverage        22.68%   22.68%           
============================================
  Files              488      488           
  Lines             5183     5183           
  Branches            21       21           
============================================
  Hits              1176     1176           
  Misses            4003     4003           
  Partials             4        4           
Impacted Files Coverage Δ
app/components/widgets/forms/link-input.js 33.33% <ø> (+1.19%) ⬆️
app/mixins/event-wizard.js 1.05% <ø> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/utils/computed-helpers.js 21.27% <33.33%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b18748...16fe22e. Read the comment docs.

@iamareebjamal iamareebjamal merged commit b739852 into fossasia:development Sep 10, 2020
@iamareebjamal iamareebjamal deleted the map-hide branch September 10, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1/Public Event Page: Switched off map option still visiblta
2 participants