Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pricing option added for anonymous users #5065

Merged
merged 5 commits into from
Sep 14, 2020

Conversation

sarthakhanda
Copy link
Contributor

@sarthakhanda sarthakhanda commented Sep 13, 2020

Fixes #5063

Short description of what this resolves:

Added Pricing link on menu for anonymous users.

Changes proposed in this pull request:

Availing Pricing link on menu for anonymous users.

Before:
before

After:
after

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel vercel bot temporarily deployed to Preview September 13, 2020 17:32 Inactive
@vercel
Copy link

vercel bot commented Sep 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9ja1a825o
✅ Preview: https://open-event-frontend-git-fork-sarthakhanda-devbugfixes.eventyay.vercel.app

@auto-label auto-label bot added fix labels Sep 13, 2020
@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #5065 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5065   +/-   ##
============================================
  Coverage        22.68%   22.68%           
============================================
  Files              488      488           
  Lines             5183     5183           
  Branches            21       21           
============================================
  Hits              1176     1176           
  Misses            4003     4003           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194b6e9...7605e1e. Read the comment docs.

@iamareebjamal
Copy link
Member

Still doesn't solve the issue

@sarthakhanda
Copy link
Contributor Author

yeah, on it. Just did a blunder

@iamareebjamal iamareebjamal merged commit d0e991a into fossasia:development Sep 14, 2020
@sarthakhanda sarthakhanda deleted the devBugFixes branch September 14, 2020 16:22
@sarthakhanda sarthakhanda restored the devBugFixes branch September 14, 2020 16:22
@sarthakhanda sarthakhanda deleted the devBugFixes branch September 14, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pricing: Link Missing on Menu on Mobile Views
2 participants