Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Seperate the admin/sales tab into 2 subtabs #5066

Merged
merged 7 commits into from
Sep 23, 2020
Merged

fix: Seperate the admin/sales tab into 2 subtabs #5066

merged 7 commits into from
Sep 23, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4954

Screenshot from 2020-09-14 13-55-39
Screenshot from 2020-09-14 13-55-34

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pb1dhbrk9
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-sessionform.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #5066 into development will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5066      +/-   ##
===============================================
+ Coverage        22.68%   22.86%   +0.17%     
===============================================
  Files              488      489       +1     
  Lines             5183     5169      -14     
  Branches            21       35      +14     
===============================================
+ Hits              1176     1182       +6     
+ Misses            4003     3982      -21     
- Partials             4        5       +1     
Impacted Files Coverage Δ
app/controllers/admin/sales/invoices.js 0.00% <ø> (ø)
app/controllers/application.js 46.15% <0.00%> (-53.85%) ⬇️
app/components/public/session-item.js 22.22% <0.00%> (-17.78%) ⬇️
app/components/forms/wizard/basic-details-step.js 18.98% <0.00%> (-2.54%) ⬇️
app/mixins/event-wizard.js 0.98% <0.00%> (-0.08%) ⬇️
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/routes/public/session/view.js 0.00% <0.00%> (ø)
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/sponsors-step.js 0.00% <0.00%> (ø)
app/controllers/account/billing/invoices/list.js 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac76d9...1167013. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

once #5049 will be merged then, I will add here the download option in invoice#

@maze-runnar
Copy link
Contributor Author

Notify button (opening a pop-up with email options depending on state)
Resend Invoice button

is there a feature available on server for sending mail for invoice?

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-14 17-36-08

@iamareebjamal
Copy link
Member

Not right now. So, let's hide that column for now and merge the PR and when there is an API, we'll show the column again

@maze-runnar maze-runnar changed the title WIP: Seperate the admin/sales tab into 2 subtabs fix: Seperate the admin/sales tab into 2 subtabs Sep 14, 2020
@auto-label auto-label bot added the fix label Sep 14, 2020
{
name : 'Action',
valuePath : 'identifier',
cellComponent : 'ui-table/cell/admin/sales/cell-action'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment it out since this is a part of current code.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for:

  • Invoice # - I dont know where that number comes from, but I guess that can also be solved in another issue
  • Dated - When looking at it it is unclear to me which date is meant (event date, invoice date, email sent date). We need to clarify this. The date should be "invoice date". Therefore please change "Dated" to "Invoice Date".

@maze-runnar
Copy link
Contributor Author

I guess that can also be solved in another issue

ok

@mariobehling
Copy link
Member

mariobehling commented Sep 23, 2020

For invoice # please use:
202009U-00001
Invoice Format
YYYYMMU-Running-Invoice-Number

@iamareebjamal
Copy link
Member

Invoice number will be handled in another PR so merging this

@iamareebjamal iamareebjamal merged commit 0125e0d into fossasia:development Sep 23, 2020
@maze-runnar maze-runnar deleted the sessionform branch September 23, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoices/Sales Admin Overview: Implement subtabs and add info about invoice status
3 participants