-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Seperate the admin/sales tab into 2 subtabs #5066
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pb1dhbrk9 |
Codecov Report
@@ Coverage Diff @@
## development #5066 +/- ##
===============================================
+ Coverage 22.68% 22.86% +0.17%
===============================================
Files 488 489 +1
Lines 5183 5169 -14
Branches 21 35 +14
===============================================
+ Hits 1176 1182 +6
+ Misses 4003 3982 -21
- Partials 4 5 +1
Continue to review full report at Codecov.
|
once #5049 will be merged then, I will add here the download option in invoice# |
is there a feature available on server for sending mail for invoice? |
Not right now. So, let's hide that column for now and merge the PR and when there is an API, we'll show the column again |
{ | ||
name : 'Action', | ||
valuePath : 'identifier', | ||
cellComponent : 'ui-table/cell/admin/sales/cell-action' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comment it out since this is a part of current code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for:
- Invoice # - I dont know where that number comes from, but I guess that can also be solved in another issue
- Dated - When looking at it it is unclear to me which date is meant (event date, invoice date, email sent date). We need to clarify this. The date should be "invoice date". Therefore please change "Dated" to "Invoice Date".
ok |
For invoice # please use: |
Invoice number will be handled in another PR so merging this |
Fixes #4954
Checklist
development
branch.