feat: add telegram & gitter social links #5069
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jqi8me7xv |
Codecov Report
@@ Coverage Diff @@
## development #5069 +/- ##
===============================================
+ Coverage 22.68% 22.79% +0.10%
===============================================
Files 488 489 +1
Lines 5183 5173 -10
Branches 21 35 +14
===============================================
+ Hits 1176 1179 +3
+ Misses 4003 3989 -14
- Partials 4 5 +1
Continue to review full report at Codecov.
|
| <div class="field"> | ||
| <label>{{t 'Gitter'}}</label> | ||
| <Widgets::Forms::LinkInput | ||
| @segmentedLink={{this.socials.segmentedGitterUrl}} |
There was a problem hiding this comment.
What do you mean?
Is it not appearing on the front-end ?
There was a problem hiding this comment.
segmentedGitterUrl does not exist
| <div class="field"> | ||
| <label>{{t 'Telegram'}}</label> | ||
| <Widgets::Forms::LinkInput | ||
| @segmentedLink={{this.socials.segmentedTelegramUrl}} |
| @@ -108,6 +108,8 @@ export default ModelBase.extend({ | |||
| segmentedFacebookUrl : computedSegmentedLink.bind(this)('facebookUrl'), | |||
| segmentedInstagramUrl : computedSegmentedLink.bind(this)('instagramUrl'), | |||
| segmentedPatreonUrl : computedSegmentedLink.bind(this)('patreonUrl'), | |||
| segmentedGitterUrl : computedSegmentedLink.bind(this)('gitterUrl'), | |||
| segmentedTelegramUrl : computedSegmentedLink.bind(this)('telegramUrl'), | |||
iamareebjamal
changed the title
|
Thanks. There is still a small issue though. As soon as I enter the link "https://" switches to "https". So, the links do not work due to missing "://". |
Requires this PR
Fixes #5022