Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore ticket clause for saving event #5105

Merged

Conversation

iamareebjamal
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ltwes0p5k
✅ Preview: https://open-event-fronten-git-fork-iamareebjamal-restore-ticket-6244c6.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #5105 into development will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5105      +/-   ##
===============================================
- Coverage        22.83%   22.80%   -0.04%     
===============================================
  Files              489      489              
  Lines             5162     5169       +7     
  Branches            35       35              
===============================================
  Hits              1179     1179              
- Misses            3978     3985       +7     
  Partials             5        5              
Impacted Files Coverage Δ
app/mixins/event-wizard.js 0.98% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3b2ae...20f923b. Read the comment docs.

@mariobehling
Copy link
Member

Thank you! Worked for me on a test event. I added a follow up issue here: #5110

@maze-runnar
Copy link
Contributor

maze-runnar commented Sep 21, 2020

Save an event as a draft with tickets -> edit event -> delete tickets , Please try this one.

@iamareebjamal
Copy link
Member Author

Draft can exist with no ticket. But should not be able to publish event without tickets

@iamareebjamal iamareebjamal merged commit 0276d00 into fossasia:development Sep 21, 2020
@iamareebjamal iamareebjamal deleted the restore-ticket-clause branch September 21, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants