-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make some admin billing fields optional #5114
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/83xmcscgc |
You still need to verify the validity of the phone number, but make it optional |
Codecov Report
@@ Coverage Diff @@
## development #5114 +/- ##
===============================================
- Coverage 22.83% 22.80% -0.04%
===============================================
Files 489 489
Lines 5162 5169 +7
Branches 35 35
===============================================
Hits 1179 1179
- Misses 3978 3985 +7
Partials 5 5
Continue to review full report at Codecov.
|
@@ -12,17 +12,22 @@ export default class Billing extends Component.extend(FormMixin) { | |||
delay : false, | |||
on : 'blur', | |||
fields : { | |||
adminBillingContactName: { | |||
identifier : 'adminBillingContactName', | |||
adminBillingEmail: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was below phone rule. So please move it there. Try to make least amount of diff as possible to make it easy to review
Fixes #5106
Checklist
development
branch.