Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make some admin billing fields optional #5114

Merged
merged 4 commits into from
Sep 22, 2020
Merged

fix: make some admin billing fields optional #5114

merged 4 commits into from
Sep 22, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5106
Screenshot from 2020-09-21 21-06-50

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/83xmcscgc
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-admin.eventyay.vercel.app

@iamareebjamal iamareebjamal changed the title enh: making fields non-required fix: making fields non-required Sep 21, 2020
@auto-label auto-label bot added the fix label Sep 21, 2020
@iamareebjamal
Copy link
Member

You still need to verify the validity of the phone number, but make it optional

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #5114 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5114      +/-   ##
===============================================
- Coverage        22.83%   22.80%   -0.04%     
===============================================
  Files              489      489              
  Lines             5162     5169       +7     
  Branches            35       35              
===============================================
  Hits              1179     1179              
- Misses            3978     3985       +7     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/forms/admin/settings/billing.js 0.00% <ø> (ø)
app/mixins/event-wizard.js 0.98% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3b2ae...60523e4. Read the comment docs.

@@ -12,17 +12,22 @@ export default class Billing extends Component.extend(FormMixin) {
delay : false,
on : 'blur',
fields : {
adminBillingContactName: {
identifier : 'adminBillingContactName',
adminBillingEmail: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was below phone rule. So please move it there. Try to make least amount of diff as possible to make it easy to review

@iamareebjamal iamareebjamal changed the title fix: making fields non-required fix: make some admin billing fields non-required Sep 22, 2020
@iamareebjamal iamareebjamal changed the title fix: make some admin billing fields non-required fix: make some admin billing fields optional Sep 22, 2020
@iamareebjamal iamareebjamal merged commit cb9178a into fossasia:development Sep 22, 2020
@maze-runnar maze-runnar deleted the admin branch September 22, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make contact name, phone and tax ID optional for invoice admin stetting
2 participants