Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partially enhance event dashboard #5139

Merged
merged 10 commits into from
Nov 3, 2020
Merged

fix: Partially enhance event dashboard #5139

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42cc15e
fix: capital the link name and change url name
Raunaksingh100 Sep 2, 2020
1f00aca
Fix:Remove row of number of revesions and remove previous change
Raunaksingh100 Sep 24, 2020
5abdd53
Fix:Remove row of number of revesions and remove previous change
Raunaksingh100 Sep 24, 2020
35e4436
Fix:Remove row of number of revesions and Capatilaze the Scoial name
Raunaksingh100 Sep 25, 2020
2b75aa4
Fix:Remove row of number of revesions and Capatilaze the Scoial name
Raunaksingh100 Sep 27, 2020
89f990f
Merge branch 'development' into dev5
mariobehling Sep 30, 2020
0ef0786
captilaze the scoial icons
Raunaksingh100 Oct 3, 2020
b640134
Revert "captilaze the scoial icons"
Raunaksingh100 Oct 3, 2020
30a3fc0
fix remove the revesion row and change external event url name
Raunaksingh100 Oct 5, 2020
7e9a9e4
fix remove the revesion row and change external event url name
Raunaksingh100 Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/social-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export default ModelBase.extend({
identifier : attr('string'), // used for providing css id for URL validations.

event: belongsTo('event'),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete the line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal according to this
1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a difference between a space and a line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal now no error

normalizedName: computed('name', function() {
// Even though name is required for social links and is non-nullable
// and non-null name is being sent from API, for some reason, for certain events,
Expand Down
11 changes: 0 additions & 11 deletions app/templates/components/events/view/overview/general-info.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,6 @@
<div class="content">
<table class="ui very basic table">
<tbody>
<tr>
<td><strong>{{t 'No. of Revisions'}}</strong></td>
<td>
<div class="muted text">
{{t 'Coming Soon'}}
</div>
{{!-- This feature is not completely available for roll out so it would pointless to diplay a dummy slidebar <a {{action 'openModal'}} role="button">
{{t '(View Revisions)'}}
</a> --}}
</td>
</tr>
<tr>
<td><strong>{{t 'Location'}}</strong></td>
<td>
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/public/social-links.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="item">
<i class="share fitted disabled icon"></i>
<div class="content">
<a href="{{this.externalUrl}}" target="_blank" rel="noopener nofollow">{{t 'External event URL'}}</a>
<a href="{{this.externalUrl}}" target="_blank" rel="noopener nofollow">{{t 'Event Site'}}</a>
</div>
</div>
{{/if}}
Expand Down