Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing error with the price of donation ticket #5148

Merged
merged 1 commit into from
Sep 28, 2020
Merged

fix: fixing error with the price of donation ticket #5148

merged 1 commit into from
Sep 28, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4475

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 25, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lw2mivg4y
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-donation.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 25, 2020
@iamareebjamal
Copy link
Member

Still happening

@maze-runnar
Copy link
Contributor Author

I have tested it several times, it's working 😕

@iamareebjamal
Copy link
Member

@edenyay is testing this soon. Let's check if her problem is solved

mariobehling
mariobehling approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eden and I tested it. Seems to be working as expected now.

@iamareebjamal iamareebjamal merged commit 30920d1 into fossasia:development Sep 28, 2020
@mariobehling
Copy link
Member

Oh, however, the error message on the ticket itself does not appear anymore.

Screenshot from 2020-09-28 17-44-11

So, solving this issue results in another issue.

@mariobehling
Copy link
Member

mariobehling commented Sep 28, 2020 •
edited
Loading

Added another issue here now #5169

iamareebjamal added a commit that referenced this pull request Sep 29, 2020
@iamareebjamal
Revert "fix: fixing error with the price of donation ticket (#5148)"
47e9c79 
This reverts commit 30920d1.
@iamareebjamal iamareebjamal mentioned this pull request Sep 29, 2020
Merged
@maze-runnar maze-runnar deleted the donation branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Counting error with the price of donation ticket
3 participants
@maze-runnar @iamareebjamal @mariobehling