Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standarize all pages to same #5152

Merged
merged 6 commits into from
Sep 28, 2020
Merged

fix: standarize all pages to same #5152

merged 6 commits into from
Sep 28, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5094

scrnli_9_25_2020_11-10-45 PM
scrnli_9_25_2020_11-10-27 PM
scrnli_9_25_2020_11-10-12 PM
scrnli_9_25_2020_11-09-50 PM

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/84i5phgmc
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-stndard.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 25, 2020
@iamareebjamal
Copy link
Member

I don't think central content column means center align text, which should never be done for content

@iamareebjamal
Copy link
Member

iamareebjamal commented Sep 25, 2020

The image is not attendee-header, rename it to app-landing-header

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #5152 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5152   +/-   ##
============================================
  Coverage        22.71%   22.71%           
============================================
  Files              489      489           
  Lines             5181     5181           
  Branches            35       35           
============================================
  Hits              1177     1177           
  Misses            3999     3999           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a0567...0dacc50. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

scrnli_9_25_2020_11-27-27 PM

@mariobehling
Copy link
Member

mariobehling commented Sep 26, 2020

Thank you.

  • App pages dont seem to have an equal spacing to the left and right, left spacing is smaller than spacing to right
  • Pricing page is missing page title header
  • Page titles are using Page Name. They should be using Title as defined in content
    Screenshot from 2020-09-26 02-41-38
  • Increase height and font on bottom bar please. Compare design and font size to Eventbrite bottom bar for inspiration e.g. here https://www.eventbrite.com/support

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this:

  • On the app pages there is still a menu on top. Please take this out.

Screenshot from 2020-09-28 07-43-13

@mariobehling
Copy link
Member

Updating the branch. Lets see if that fixes the Travis build fail.

@iamareebjamal iamareebjamal merged commit e337ee4 into fossasia:development Sep 28, 2020
@maze-runnar maze-runnar deleted the stndard branch September 28, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Content: Standardize Pages - Terms, Privacy etc.
3 participants