Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace getWithDefault with nullish coalescing #5205

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 30, 2020

@vercel
Copy link

vercel bot commented Sep 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4z6kmw7ih
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-get-with-default.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/router.js  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #5205 into development will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5205      +/-   ##
===============================================
- Coverage        22.68%   22.63%   -0.06%     
===============================================
  Files              489      490       +1     
  Lines             5198     5201       +3     
  Branches            36       36              
===============================================
- Hits              1179     1177       -2     
- Misses            4014     4019       +5     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/modals/cropper-modal.js 0.00% <0.00%> (ø)
app/components/orders/order-summary.js 29.41% <0.00%> (ø)
app/controllers/events/view/tickets/add-order.js 0.00% <0.00%> (ø)
app/router.js 100.00% <100.00%> (ø)
app/components/tabbed-navigation.js 26.66% <0.00%> (-20.01%) ⬇️
app/routes/event-invoice/review.js 0.00% <0.00%> (ø)
app/components/ui-table/cell/cell-date.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9223879...c31f6c5. Read the comment docs.

@iamareebjamal iamareebjamal merged commit f3151a3 into fossasia:development Oct 1, 2020
@iamareebjamal iamareebjamal deleted the get-with-default branch October 1, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants