Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't jump to main page or step 3 in wizard #5225

Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix: don't jump to main page or step 3 in wizard #5225

merged 1 commit into from
Oct 2, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5187

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ar1qgltf9
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-redirect-wizard.eventyay.vercel.app

@@ -17,7 +17,7 @@ export default class EditRoute extends Route.extend(AuthenticatedRouteMixin, Eve

const event = this.modelFor('events.view');
const { currentUser } = this.authManager;
if (!(currentUser.isAnAdmin || currentUser.email === event.owner.get('email') || event.organizers.includes(currentUser)
if (!(currentUser.isAnAdmin || (currentUser.email === event.owner.get('email') || !event.owner.get('email')) || event.organizers.includes(currentUser)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when initially creating an event the owner email is null

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #5225 into development will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5225      +/-   ##
===============================================
- Coverage        22.75%   22.69%   -0.06%     
===============================================
  Files              490      490              
  Lines             5199     5199              
  Branches            36       36              
===============================================
- Hits              1183     1180       -3     
- Misses            4011     4014       +3     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/create.js 0.00% <ø> (ø)
app/routes/events/view/edit.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 26.66% <0.00%> (-20.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55e82b...65d5e05. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix:don't jump to main page or step 3 in wizard fix: don't jump to main page or step 3 in wizard Oct 2, 2020
@iamareebjamal iamareebjamal merged commit c5b9a0f into fossasia:development Oct 2, 2020
@maze-runnar maze-runnar deleted the redirect-wizard branch October 2, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Event: After Step 1 it "Next" jumps to Step 3
2 participants