Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding table for admin-sales-by-event #5243

Merged
merged 5 commits into from
Oct 6, 2020
Merged

fix: adding table for admin-sales-by-event #5243

merged 5 commits into from
Oct 6, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Oct 5, 2020

Fixes #2794
Fixes #5163
Screenshot from 2020-10-05 21-04-39

Screenshot from 2020-10-05 21-09-42

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fsv8649hw
✅ Preview: https://open-event-fronten-git-403f3a10ab6d32626f87500b7094e74b7-b7f16b.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #5243 into development will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5243      +/-   ##
===============================================
- Coverage        22.75%   22.72%   -0.04%     
===============================================
  Files              490      491       +1     
  Lines             5207     5215       +8     
  Branches            36       36              
===============================================
  Hits              1185     1185              
- Misses            4017     4025       +8     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/admin/sales/index.js 0.00% <0.00%> (ø)
app/routes/admin/sales/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd7cc8...403f3a1. Read the comment docs.

@iamareebjamal
Copy link
Member

Please group the status sales like in previous UI and use standard date cell like in invoice table

@iamareebjamal
Copy link
Member

Currency and correct date format is missing as well

Previous UI:
image

@maze-runnar
Copy link
Contributor Author

scrnli_10_6_2020_12-20-24 AM

@iamareebjamal
Copy link
Member

Please group the status sales like in previous UI and use standard date cell like in invoice table

Date is still in wrong format. Please check all points before finalizing

@iamareebjamal
Copy link
Member

Amount column doesn't show anything, just 0 always. And build is also failing

@iamareebjamal
Copy link
Member

Please see last commit. Many changes were unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants