Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow admin to search users by lastName and email #5246

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 6, 2020

Fixes #5081

@vercel
Copy link

vercel bot commented Oct 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9ekl5k1nk
✅ Preview: https://open-event-fronten-git-9f9c7804b875562cfa1b01495372c5022-cd2e16.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/mixins/ember-table-route.js  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #5246 into development will increase coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5246      +/-   ##
===============================================
+ Coverage        22.75%   22.78%   +0.02%     
===============================================
  Files              490      491       +1     
  Lines             5207     5223      +16     
  Branches            36       36              
===============================================
+ Hits              1185     1190       +5     
- Misses            4017     4028      +11     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/admin/users/list.js 0.00% <0.00%> (ø)
app/routes/admin/users/list.js 0.00% <0.00%> (ø)
app/mixins/ember-table-route.js 75.00% <72.72%> (-1.93%) ⬇️
app/routes/admin/sales/index.js 0.00% <0.00%> (ø)
app/controllers/admin/sales/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd7cc8...9f9c780. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 9b346b3 into fossasia:development Oct 6, 2020
@iamareebjamal iamareebjamal deleted the admin-user-search branch October 6, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: Sort users according to signup date and ensure search for names and emails works
2 participants