Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow scheduler slot duration of 5 min #5346

Merged
merged 1 commit into from
Oct 21, 2020
Merged

feat: allow scheduler slot duration of 5 min #5346

merged 1 commit into from
Oct 21, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5345

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fn3lygk52
✅ Preview: https://open-event-frontend-git-scheduler-time-interval.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #5346 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5346      +/-   ##
===============================================
+ Coverage        22.78%   22.84%   +0.05%     
===============================================
  Files              491      491              
  Lines             5245     5245              
  Branches            37       37              
===============================================
+ Hits              1195     1198       +3     
+ Misses            4045     4042       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/models/event.js 50.00% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63929e3...daa6c2a. Read the comment docs.

@iamareebjamal iamareebjamal changed the title enh: change scheduler slot duration to 5 min feat: allow scheduler slot duration of 5 min Oct 21, 2020
@iamareebjamal
Copy link
Member

Thanks @maze-runnar

@auto-label auto-label bot added the feature label Oct 21, 2020
@iamareebjamal iamareebjamal merged commit 0f4aabf into fossasia:development Oct 21, 2020
@maze-runnar maze-runnar deleted the scheduler-time-interval branch October 22, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler: Allow 5 minute separation of sessions
2 participants