feat: Add to Calendar - iCal

[akash2408]

Fixes #5072

Short description of what this resolves:

i added yahoo and outlook calendar and dropdown

Changes proposed in this pull request:

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fuxicmwok
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

[mariobehling]

Please improve as follows:

• add ical which is the most important we need right now
• Outlook is not working, please help to fix it
• Yahoo not working neither on test page

[codecov]

Codecov Report

Merging #5440 into development will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #5440      +/-   ##
===============================================
- Coverage        23.23%   23.19%   -0.04%     
===============================================
  Files              493      493              
  Lines             5169     5182      +13     
  Branches            38       38              
===============================================
+ Hits              1201     1202       +1     
- Misses            3963     3975      +12     
  Partials             5        5              

Impacted Files	Coverage Δ
app/components/public/add-to-calender.ts	4.54% <0.00%> (-4.55%)	⬇️
app/services/loader.js	39.56% <0.00%> (-0.44%)	⬇️
app/components/nav-bar.js	33.33% <0.00%> (+33.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b31d31...101611b. Read the comment docs.

[iamareebjamal]

There is already an ical URL in the event model

[akash2408]

There is already an ical URL in the event model

I added the iCalUrl from the event model.

[iamareebjamal]

I have no idea why you remove target blank and rel nofollow noreferrer. There is a reason why I added that

[akash2408]

Ohh Sorry i just forget that

…

On Wed, Nov 4, 2020, 14:47 Areeb Jamal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/components/public/add-to-calender.hbs <#5440 (comment)> : > @@ -9,7 +9,16 @@ {{/if}} ({{this.timezone}}) <br> - <a href={{this.calendarUrl}} target="_blank" rel="noreferrer nofollow">{{t 'Add to Google Calendar'}}</a> + <UiDropdown class="pointing"> + <a href="#">{{t 'Add to Calendar'}}</a> + <div class="menu"> + {{#each this.calendarUrls as |calendar|}} + <a href={{calendar.url}} class="item"> I have no idea why you remove target blank and rel nofollow noreferrer. There is a reason why I added that — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5440 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOTTIAALF2XGLSVRIICEFS3SOEL3NANCNFSM4TGSCKTQ> .

[mariobehling]

When I download the ical it is missing .ics. I am getting a file 1f720482-Open Source Day 2020 - Forum digitale_. Please add the ics ending. Thanks!

[mariobehling]

I am referring to this example event https://eventyay.com/e/1f720482

[iamareebjamal]

I'm getting 1f720482-Open Source Day 2020 - Forum für digitale Souveränität-Calendar.ics. Which browser were you using?

[akash2408]

When I download the ical it is missing .ics. I am getting a file 1f720482-Open Source Day 2020 - Forum digitale_. Please add the ics ending. Thanks!