Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't cfs filter when cfs is disabled #5583

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix: don't cfs filter when cfs is disabled #5583

merged 3 commits into from
Nov 12, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5578

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/coaxmozur
✅ Preview: https://open-event-frontend-git-cfs-filter.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5583 (2b4bddd) into development (a0d1679) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5583      +/-   ##
===============================================
- Coverage        23.71%   23.70%   -0.01%     
===============================================
  Files              498      498              
  Lines             5255     5257       +2     
  Branches            44       44              
===============================================
  Hits              1246     1246              
- Misses            4003     4005       +2     
  Partials             6        6              
Impacted Files Coverage Δ
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)
app/routes/index.js 78.57% <ø> (ø)
app/controllers/admin/users/list.js 0.00% <0.00%> (ø)
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1679...2b4bddd. Read the comment docs.

val : {
name : 'announcement',
op : 'ne',
val : ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If speaker call is being disabled, announcement should be set to null, not empty string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's giving error field may not be null.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it nullable in server please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

announcement = db.Column(db.Text, nullable=True) do i have to migrate also after making it nullable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change in schema means migration

@iamareebjamal iamareebjamal merged commit ff1d83c into fossasia:development Nov 12, 2020
@maze-runnar maze-runnar deleted the cfs-filter branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call for Speakers: Event Showing Up on Frontpage even though CfS is deactivated
2 participants