-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't cfs filter when cfs is disabled #5583
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/coaxmozur |
Codecov Report
@@ Coverage Diff @@
## development #5583 +/- ##
===============================================
- Coverage 23.71% 23.70% -0.01%
===============================================
Files 498 498
Lines 5255 5257 +2
Branches 44 44
===============================================
Hits 1246 1246
- Misses 4003 4005 +2
Partials 6 6
Continue to review full report at Codecov.
|
app/routes/index.js
Outdated
val : { | ||
name : 'announcement', | ||
op : 'ne', | ||
val : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If speaker call is being disabled, announcement should be set to null, not empty string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's giving error field may not be null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it nullable in server please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
announcement = db.Column(db.Text, nullable=True)
do i have to migrate also after making it nullable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change in schema means migration
Fixes #5578
Checklist
development
branch.