-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Company field validation in form #5607
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fqaxnf6zj |
Codecov Report
@@ Coverage Diff @@
## development #5607 +/- ##
===============================================
+ Coverage 23.25% 23.73% +0.48%
===============================================
Files 493 498 +5
Lines 5182 5270 +88
Branches 38 47 +9
===============================================
+ Hits 1205 1251 +46
- Misses 3972 4011 +39
- Partials 5 8 +3
Continue to review full report at Codecov.
|
@@ -202,7 +202,6 @@ export default Component.extend(FormMixin, { | |||
}; | |||
|
|||
const companyValidation = { | |||
identifier : 'company', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's resolving the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why was it creating it?
Fixes #5602
Before
After
Checklist
development
branch.