Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Company field validation in form #5607

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

Saumyachitransh01
Copy link
Member

Fixes #5602
Before
Screenshot from 2020-11-13 18-33-33

After
Screenshot from 2020-11-13 18-23-32

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fqaxnf6zj
✅ Preview: https://open-event-frontend-git-form.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5607 (2dbdcbf) into development (5bbb10c) will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5607      +/-   ##
===============================================
+ Coverage        23.25%   23.73%   +0.48%     
===============================================
  Files              493      498       +5     
  Lines             5182     5270      +88     
  Branches            38       47       +9     
===============================================
+ Hits              1205     1251      +46     
- Misses            3972     4011      +39     
- Partials             5        8       +3     
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/utils/computed-helpers.js 19.56% <0.00%> (-1.72%) ⬇️
app/components/modals/modal-base.js 24.24% <0.00%> (-0.76%) ⬇️
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️
app/routes/index.js 78.57% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/controllers/register.js 34.28% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/routes/public/cfs/index.js 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbb10c...2dbdcbf. Read the comment docs.

@@ -202,7 +202,6 @@ export default Component.extend(FormMixin, {
};

const companyValidation = {
identifier : 'company',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's resolving the issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why was it creating it?

@iamareebjamal iamareebjamal changed the title Custom Form correction fix: Company field validation in form Nov 13, 2020
@iamareebjamal iamareebjamal merged commit e3c265f into fossasia:development Nov 13, 2020
@auto-label auto-label bot added the fix label Nov 13, 2020
@Saumyachitransh01 Saumyachitransh01 deleted the form branch November 13, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attendee Custom Form: No error message on some fields and changed order on live form
2 participants