fix: don't trigger submit action twice #5658

maze-runnar · 2020-11-16T09:18:56Z

currently made changes for billing section.

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-11-16T09:19:01Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/qujlt09ce
✅ Preview: https://open-event-frontend-git-twice-action.eventyay.vercel.app

codecov · 2020-11-16T09:30:56Z

Codecov Report

Merging #5658 (6d40195) into development (9dfeef4) will decrease coverage by 0.30%.
The diff coverage is 33.33%.

@@               Coverage Diff               @@
##           development    #5658      +/-   ##
===============================================
- Coverage        23.73%   23.43%   -0.31%     
===============================================
  Files              498      508      +10     
  Lines             5275     5377     +102     
  Branches            47       47              
===============================================
+ Hits              1252     1260       +8     
- Misses            4015     4109      +94     
  Partials             8        8

Impacted Files	Coverage Δ
app/components/forms/admin/settings/billing.js	`0.00% <0.00%> (ø)`
app/components/forms/orders/order-form.js	`0.00% <ø> (ø)`
app/components/forms/user-payment-info-form.js	`26.66% <0.00%> (-1.91%)`	⬇️
app/components/forms/login-form.js	`60.60% <100.00%> (+1.23%)`	⬆️
app/components/modals/modal-base.js	`22.85% <0.00%> (-1.39%)`	⬇️
app/router.js	`100.00% <0.00%> (ø)`
app/routes/index.js	`78.57% <0.00%> (ø)`
app/serializers/event-statistics-general.js	`0.00% <0.00%> (ø)`
app/controllers/events/view/tickets/orders/list.js	`0.00% <0.00%> (ø)`
.../controllers/events/view/tickets/attendees/list.js	`0.00% <0.00%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfeef4...6d40195. Read the comment docs.

iamareebjamal · 2020-11-16T09:50:26Z

Can I submit the form by clicking enter on any field. And this is not the only form with class syntax

maze-runnar · 2020-11-16T11:02:32Z

Can I submit the form by clicking enter on any field.

Yes

iamareebjamal · 2020-11-16T11:05:12Z

app/templates/components/forms/admin/settings/billing.hbs

@@ -88,5 +88,5 @@
    <label for="adminBillingAdditionalInfo">{{t 'Additional Info'}}</label>
    <Input @type="text" @id="adminBillingAdditionalInfo" @value={{this.model.adminBillingAdditionalInfo}} />
  </div>
-  <button class="ui teal button" type="submit" name="submit">{{t 'Save'}}</button>
+  <button class="ui teal button" type="button" name="submit" onclick={{action "submit"}}>{{t 'Save'}}</button>


I don't think this should be needed, just type="submit" should do

keeping it to submit that is triggering twice

maze-runnar · 2020-11-17T04:19:52Z

@iamareebjamal why build is failing Error: Element not found when calling click('button[type=submit]')``` acceptance test. `

iamareebjamal · 2020-11-17T04:23:32Z

Because there is no submit type button in the form now.

Honestly, it should work without changing button submit, check here - 5c3d8f5

maze-runnar · 2020-11-17T04:25:52Z

ok

maze-runnar · 2020-11-18T07:27:26Z

@iamareebjamal please review.

iamareebjamal · 2020-11-18T07:51:29Z

app/templates/components/forms/admin/settings/billing.hbs

@@ -88,5 +88,5 @@
    <label for="adminBillingAdditionalInfo">{{t 'Additional Info'}}</label>
    <Input @type="text" @id="adminBillingAdditionalInfo" @value={{this.model.adminBillingAdditionalInfo}} />
  </div>
-  <button class="ui teal button" type="submit" name="submit">{{t 'Save'}}</button>
+  <button class="ui teal button" type="submit" name="submit" onclick={{action "submit"}}>{{t 'Save'}}</button>


Is it needed?

iamareebjamal · 2020-11-18T07:55:11Z

app/templates/components/forms/login-form.hbs

@@ -35,7 +35,7 @@
          </div>
          <div class="ui center aligned segment basic">
            <div class="ui vertical buttons">
-              <button type="submit" class="ui fluid teal submit button register">
+              <button type="submit" class="ui fluid teal submit button register" onclick={{action "submit"}}>


Is this change needed?

no it's not 😕 . But why, I don't understand. If my action name is other than submit then it will be needed or will work in same way?

Dunno, looks like the form mixin shenanigans

it helps

db5a94f

auto-label bot added the fix label Nov 16, 2020

vercel bot deployed to Preview November 16, 2020 09:19 View deployment

iamareebjamal reviewed Nov 16, 2020

View reviewed changes

maze-runnar added 2 commits November 16, 2020 17:01

one more..

10cd1ef

changes

6317cb2

vercel bot deployed to Preview November 16, 2020 12:05 View deployment

f

f33e40e

vercel bot deployed to Preview November 16, 2020 12:09 View deployment

f

e07f7a1

vercel bot deployed to Preview November 16, 2020 12:36 View deployment

fixing my mistake

46eaa2d

vercel bot deployed to Preview November 17, 2020 05:21 View deployment

usual error

148a16d

vercel bot deployed to Preview November 17, 2020 05:25 View deployment

iamareebjamal reviewed Nov 18, 2020

View reviewed changes

removing..

57b4200

vercel bot deployed to Preview November 18, 2020 11:48 View deployment

s

6d40195

vercel bot deployed to Preview November 18, 2020 11:53 View deployment

iamareebjamal approved these changes Nov 18, 2020

View reviewed changes

iamareebjamal merged commit aa99edd into fossasia:development Nov 18, 2020

maze-runnar deleted the twice-action branch November 18, 2020 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: don't trigger submit action twice #5658

fix: don't trigger submit action twice #5658

maze-runnar commented Nov 16, 2020

vercel bot commented Nov 16, 2020 •

edited

Loading

codecov bot commented Nov 16, 2020 •

edited

Loading

iamareebjamal commented Nov 16, 2020

maze-runnar commented Nov 16, 2020

iamareebjamal Nov 16, 2020

maze-runnar Nov 16, 2020

maze-runnar commented Nov 17, 2020

iamareebjamal commented Nov 17, 2020

maze-runnar commented Nov 17, 2020

maze-runnar commented Nov 18, 2020

iamareebjamal Nov 18, 2020

iamareebjamal Nov 18, 2020

maze-runnar Nov 18, 2020

iamareebjamal Nov 18, 2020

fix: don't trigger submit action twice #5658

fix: don't trigger submit action twice #5658

Conversation

maze-runnar commented Nov 16, 2020

Checklist

vercel bot commented Nov 16, 2020 • edited Loading

codecov bot commented Nov 16, 2020 • edited Loading

Codecov Report

iamareebjamal commented Nov 16, 2020

maze-runnar commented Nov 16, 2020

iamareebjamal Nov 16, 2020

Choose a reason for hiding this comment

maze-runnar Nov 16, 2020

Choose a reason for hiding this comment

maze-runnar commented Nov 17, 2020

iamareebjamal commented Nov 17, 2020

maze-runnar commented Nov 17, 2020

maze-runnar commented Nov 18, 2020

iamareebjamal Nov 18, 2020

Choose a reason for hiding this comment

iamareebjamal Nov 18, 2020

Choose a reason for hiding this comment

maze-runnar Nov 18, 2020

Choose a reason for hiding this comment

iamareebjamal Nov 18, 2020

Choose a reason for hiding this comment

vercel bot commented Nov 16, 2020 •

edited

Loading

codecov bot commented Nov 16, 2020 •

edited

Loading