Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table with ticket details is not responsive in phone #5662

Merged
merged 6 commits into from
Nov 20, 2020
Merged

fix: table with ticket details is not responsive in phone #5662

merged 6 commits into from
Nov 20, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 16, 2020

Fixes #3511

Short description of what this resolves:

Ticket table was breaking in mobile responsive view when one of the ticket type is donation ticket.
Compare - https://open-event-frontend.now.sh/e/a315169f (in mobile view)

Changes proposed in this pull request:

  • Removed an empty column after type and added after price.
  • Removed class for input for donation tickets which was producing bug.

Before

(with Donation tickets)
Screen Shot 2020-11-16 at 23 21 58

(without Donation tickets)
Screen Shot 2020-11-16 at 23 28 26

After

(with Donation tickets)
Screen Shot 2020-11-16 at 23 29 31

(without Donation tickets)
Screen Shot 2020-11-16 at 23 32 55

(other screenshots for different screen size)
Screen Shot 2020-11-16 at 23 35 58

Screen Shot 2020-11-16 at 23 34 50

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lo6v10bst
✅ Preview: https://open-event-frontend-git-ticket-table-resp-3511.eventyay.now.sh

@divyamtayal
Copy link
Member Author

@iamareebjamal Please see the changes I have made and let me know to make any changes further.
This looks good to me. as now in every possibly situation ticket Table is responsive and nicely aligned.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #5662 (060859f) into development (70c2285) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5662      +/-   ##
===============================================
- Coverage        23.62%   23.57%   -0.06%     
===============================================
  Files              510      510              
  Lines             5417     5417              
  Branches            59       59              
===============================================
- Hits              1280     1277       -3     
- Misses            4121     4124       +3     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c2285...060859f. Read the comment docs.

@divyamtayal
Copy link
Member Author

@iamareebjamal PLease see the changes

@maze-runnar
Copy link
Contributor

Not working -
scrnli_11_19_2020_2-41-49 PM
scrnli_11_19_2020_2-41-15 PM

@divyamtayal
Copy link
Member Author

divyamtayal commented Nov 19, 2020

Not working -

@iamareebjamal @maze-runnar I want to know till which point or min-width for which it should not break.

@divyamtayal
Copy link
Member Author

divyamtayal commented Nov 20, 2020

@iamareebjamal @maze-runnar Plese let me know
can we just not display subtotal field in mobile view bcz otherwise the table looks so untidy and I think subtotal field could be removed and will not disturb the logic or user exp for user and also not displaying subtotal field leads to easy repressiveness of table.

@iamareebjamal
Copy link
Member

Subtotal is important, reaarange price field for donation ticket

@divyamtayal
Copy link
Member Author

Not working -

@iamareebjamal @maze-runnar I want to know till which point or min-width for which it should not break.

??

@iamareebjamal
Copy link
Member

Smallest width device preset in your browser

@divyamtayal
Copy link
Member Author

divyamtayal commented Nov 20, 2020

@iamareebjamal I found this to be a nice way in mobile device making tables stackable. What do you want to say about this?
Screen Shot 2020-11-20 at 12 07 06
I think with this we are getting all the information without compromising the space and looks tidy

@iamareebjamal
Copy link
Member

Looks good

@divyamtayal
Copy link
Member Author

divyamtayal commented Nov 20, 2020

Looks good

@iamareebjamal further more changes?

@iamareebjamal iamareebjamal changed the title The table with ticket details is not responsive in phone fix: table with ticket details is not responsive in phone Nov 20, 2020
@auto-label auto-label bot added the fix label Nov 20, 2020
@iamareebjamal iamareebjamal merged commit 34df828 into fossasia:development Nov 20, 2020
@divyamtayal divyamtayal deleted the ticket-table-resp-3511 branch November 23, 2020 00:44
Copy link
Member Author

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table with ticket details is not responsive in phone.
3 participants