-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: table with ticket details is not responsive in phone #5662
fix: table with ticket details is not responsive in phone #5662
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lo6v10bst |
@iamareebjamal Please see the changes I have made and let me know to make any changes further. |
Codecov Report
@@ Coverage Diff @@
## development #5662 +/- ##
===============================================
- Coverage 23.62% 23.57% -0.06%
===============================================
Files 510 510
Lines 5417 5417
Branches 59 59
===============================================
- Hits 1280 1277 -3
- Misses 4121 4124 +3
Partials 16 16
Continue to review full report at Codecov.
|
@iamareebjamal PLease see the changes |
@iamareebjamal @maze-runnar I want to know till which point or min-width for which it should not break. |
@iamareebjamal @maze-runnar Plese let me know |
Subtotal is important, reaarange price field for donation ticket |
?? |
Smallest width device preset in your browser |
@iamareebjamal I found this to be a nice way in mobile device making tables stackable. What do you want to say about this? |
Looks good |
@iamareebjamal further more changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Fixes #3511
Short description of what this resolves:
Ticket table was breaking in mobile responsive view when one of the ticket type is donation ticket.
Compare - https://open-event-frontend.now.sh/e/a315169f (in mobile view)
Changes proposed in this pull request:
Before
(with Donation tickets)
(without Donation tickets)
After
(with Donation tickets)
(without Donation tickets)
(other screenshots for different screen size)
Checklist
development
branch.