Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make listed areas translatable #5701

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 20, 2020

Fixes #5609

Short description of what this resolves:

This Pr make all listed area translatable.

areas that are make translatable:-

  • Dashboard
    sa1

  • Speakers
    sa2

  • Sessions and session filters
    sa3

  • Session columns: Accepted and other statuses
    sac1

  • Admin sections
    sa5
    sa6
    sa7
    sa8
    sa9
    sa10
    sa11

  • Wizard

  • Location/Online

  • Dropdown event types etc.

  • Custom Attendee Form fields
    sa12

  • Publication sentence on wizard bottom

  • Speaker and Session form

  • Frontpage and Search

  • Tags

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/aue5udae0
✅ Preview: https://open-event-frontend-git-fix-5609.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #5701 (4f1edd9) into development (52a5796) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5701   +/-   ##
============================================
  Coverage        23.62%   23.62%           
============================================
  Files              510      510           
  Lines             5417     5417           
  Branches            59       59           
============================================
  Hits              1280     1280           
- Misses            4121     4122    +1     
+ Partials            16       15    -1     
Impacted Files Coverage Δ
app/controllers/admin/events/list.js 0.00% <ø> (ø)
app/controllers/admin/messages/list.js 0.00% <ø> (ø)
...rollers/admin/reports/system-logs/activity-logs.js 0.00% <ø> (ø)
...controllers/admin/reports/system-logs/mail-logs.js 0.00% <ø> (ø)
...ers/admin/reports/system-logs/notification-logs.js 0.00% <ø> (ø)
app/controllers/admin/sales/index.js 0.00% <ø> (ø)
app/controllers/admin/sales/invoices.js 0.00% <ø> (ø)
app/controllers/admin/sessions/list.js 0.00% <ø> (ø)
app/controllers/admin/users/list.js 0.00% <ø> (ø)
app/controllers/events/list.js 9.09% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a5796...4f1edd9. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 975272a into fossasia:development Nov 21, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the fix-5609 branch November 21, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations: Make all areas translatable
3 participants