-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dropdown menu results in internal scroll bar #5766
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/aovwxvyp8 |
Codecov Report
@@ Coverage Diff @@
## development #5766 +/- ##
===============================================
- Coverage 23.64% 23.32% -0.32%
===============================================
Files 510 513 +3
Lines 5414 5457 +43
Branches 59 62 +3
===============================================
- Hits 1280 1273 -7
- Misses 4118 4168 +50
Partials 16 16
Continue to review full report at Codecov.
|
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution works for me. Thanks.
Unfortunately, this causes #5834, so have to revert |
This reverts commit 4c59354.
Fixes #5307
Short description of what this resolves:
Table height is adjusted to wax and wane automatically and dropdown direction is calculated properly.
Changes proposed in this pull request:
-Table::Default component is patched to emit action of rendering end.
-Pre-calculation of dropdown direction is implemented
-CellButton component is modified to add direction option
Checklist
development
branch.