Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Schedule: Show date and time in left column #5772

Merged
merged 4 commits into from
Nov 27, 2020
Merged

feat: Schedule: Show date and time in left column #5772

merged 4 commits into from
Nov 27, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 26, 2020

Fixes #5762

Short description of what this resolves:

Show Date and time in a column on the left

ScreenShots

Screenshot_2020-11-26 Sessions Robotics Open Event
Screenshot_2020-11-26 Sessions Robotics Open Event(1)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/qtvnfe0sh
✅ Preview: https://open-event-frontend-git-date-time-5762.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #5772 (d3718c8) into development (df1d513) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5772      +/-   ##
===============================================
- Coverage        23.40%   23.39%   -0.01%     
===============================================
  Files              513      512       -1     
  Lines             5481     5436      -45     
  Branches            62       62              
===============================================
- Hits              1283     1272      -11     
+ Misses            4182     4148      -34     
  Partials            16       16              
Impacted Files Coverage Δ
app/models/event.js 50.00% <0.00%> (ø)
app/models/session.js 10.00% <0.00%> (ø)
app/models/speaker.js 0.00% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/components/widgets/forms/link-input.js
app/models/custom-form.js 30.76% <0.00%> (+2.19%) ⬆️
app/utils/computed-helpers.js 24.13% <0.00%> (+4.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d513...d3718c8. Read the comment docs.

@iamareebjamal
Copy link
Member

Mixed 24 hour time and 12 hour time. Use general date helper with 12 hour time so it works correctly with #5748

@iamareebjamal
Copy link
Member

Remove horizontal line and add vertical line

@mariobehling
Copy link
Member

Please also change the following:

  • Time font needs to be larger to be visible
  • Use a darker gray. It is too light. Difficult to see.
  • Time in left column is not in one visual line with text on the right hand side

@divyamtayal
Copy link
Member Author

Screenshot_2020-11-26 Sessions Robotics Open Event(2)
Screenshot_2020-11-26 Sessions Robotics Open Event(3)

@divyamtayal
Copy link
Member Author

@iamareebjamal Pls let me know to make any changes in UI

@iamareebjamal iamareebjamal changed the title Schedule: Show date and time in left column feat: Schedule: Show date and time in left column Nov 27, 2020
@iamareebjamal iamareebjamal merged commit 91fb290 into fossasia:development Nov 27, 2020
@auto-label auto-label bot added the feature label Nov 27, 2020
@divyamtayal divyamtayal deleted the date-time-5762 branch November 27, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule: Show date and time in left column
3 participants