Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preselect Ticket holder same as Ticket Buyer in Order Form #5859

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

MeghalBisht
Copy link
Member

Fixes #5851

Short description of what this resolves:

Checkbox for selecting ticket holder same as ticket buyer is checked initially (with details displayed). User can toggle to turn it off.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [] I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Dec 1, 2020
@vercel
Copy link

vercel bot commented Dec 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4vr4kiff3
✅ Preview: https://open-event-frontend-git-ticket-5851.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #5859 (6ca48df) into development (91fb290) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5859      +/-   ##
===============================================
- Coverage        23.45%   23.44%   -0.01%     
===============================================
  Files              512      512              
  Lines             5445     5464      +19     
  Branches            63       63              
===============================================
+ Hits              1277     1281       +4     
- Misses            4152     4167      +15     
  Partials            16       16              
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/helpers/general-date.js 66.66% <0.00%> (-33.34%) ⬇️
app/components/public/session-item.js 14.28% <0.00%> (-5.72%) ⬇️
app/controllers/public/index.js 6.25% <0.00%> (-0.10%) ⬇️
app/routes/create.js 100.00% <0.00%> (ø)
app/models/speaker.js 0.00% <0.00%> (ø)
app/components/public/call-for-speakers.js 0.00% <0.00%> (ø)
app/components/public/stream/video-stream.ts 4.00% <0.00%> (ø)
app/controllers/events/view/videoroom/list.js 0.00% <0.00%> (ø)
app/helpers/header-date.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fb290...6ca48df. Read the comment docs.

@MeghalBisht
Copy link
Member Author

Just noticed that if someone selects more than one ticket all the tickets will get the same name as the buyer. What can be a better solution for this?

@mariobehling
Copy link
Member

Just noticed that if someone selects more than one ticket all the tickets will get the same name as the buyer. What can be a better solution for this?

This only happens in your PR, not in the current system. Only the first person should have the name added even if the ticket holder field is pre-selected.

@MeghalBisht
Copy link
Member Author

Just noticed that if someone selects more than one ticket all the tickets will get the same name as the buyer. What can be a better solution for this?

This only happens in your PR, not in the current system. Only the first person should have the name added even if the ticket holder field is pre-selected.

Yes, I noticed the bug in my PR after I opened it. Hope it's good now

@iamareebjamal iamareebjamal merged commit b95b93a into fossasia:development Dec 2, 2020
@mariobehling
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preselect "Ticket holder" same as "Ticket Buyer
4 participants