Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch pages before findBy #5876

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Dec 2, 2020

Fixes #5875

In #5775, application stopped loading pages as its model and since, the footer pages were broken

@auto-label auto-label bot added the fix label Dec 2, 2020
@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3m0fx4c3k
✅ Preview: https://open-event-frontend-git-pages-findby.eventyay.now.sh

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #5876 (2702436) into development (b5863f5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5876   +/-   ##
============================================
  Coverage        23.41%   23.41%           
============================================
  Files              511      511           
  Lines             5472     5472           
  Branches            65       65           
============================================
  Hits              1281     1281           
  Misses            4174     4174           
  Partials            17       17           
Impacted Files Coverage Δ
app/routes/pages.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5863f5...2702436. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 308d268 into fossasia:development Dec 2, 2020
@iamareebjamal iamareebjamal deleted the pages-findby branch December 2, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'findBy' of undefined
1 participant