Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set min time in calendar #5997

Merged
merged 3 commits into from
Dec 31, 2020
Merged

fix: set min time in calendar #5997

merged 3 commits into from
Dec 31, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4996

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/a7ewywl98
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-min-time.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #5997 (0a23e02) into development (0513cec) will decrease coverage by 0.50%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5997      +/-   ##
===============================================
- Coverage        23.47%   22.97%   -0.51%     
===============================================
  Files              511      522      +11     
  Lines             5466     5694     +228     
  Branches            67      110      +43     
===============================================
+ Hits              1283     1308      +25     
- Misses            4166     4357     +191     
- Partials            17       29      +12     
Impacted Files Coverage Δ
app/components/schedule.ts 52.72% <0.00%> (-9.50%) ⬇️
app/components/order-card.js 30.76% <0.00%> (-69.24%) ⬇️
app/components/event-card.js 53.84% <0.00%> (-18.89%) ⬇️
app/components/side-bar.js 78.94% <0.00%> (-14.81%) ⬇️
app/routes/explore.js 47.05% <0.00%> (-9.70%) ⬇️
app/components/nav-bar.js 25.00% <0.00%> (-8.34%) ⬇️
app/components/explore/side-bar.js 12.50% <0.00%> (-3.90%) ⬇️
app/controllers/application.js 43.75% <0.00%> (-2.41%) ⬇️
...pp/components/events/view/overview/manage-roles.js 6.45% <0.00%> (-0.96%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0513cec...0a23e02. Read the comment docs.

this.args.sessions.map(x => {
const z = String(x.startsAt.format('HH:mm:ss'));
if (min_time > z) {
min_time = z;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not working on string values

@mariobehling
Copy link
Member

mariobehling commented Dec 24, 2020

What does this exactly solve? Which minimum time? For the scheduler? We had defined 5 minutes previously. Do you plan a change here?

Please always add screenshots to areas you work on. This makes everything easier.

@maze-runnar
Copy link
Contributor Author

it sets min starting time in calendar based on session starting time.

Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is working fine for public page. suppose my event start from 21 jan 00:00 am to 21 jan 23:00 pm. My first session is from 07:00 am. At public page, calendar starts from 07:00 am.
But this is problematic for organizers. At scheduler page also calendar starts from 07:00 am.
example: my sessions start from 00:00 am to 23:00 pm. I want to schedule my sessions. calendar at scheduler page starts from 00:00 am to 23:00pm. I schedule my first session at 07:00 am. Now after this calendar at scheduler show time from 07:00 am to 23:00pm. Now I can't schedule any sessions before 07:00 am as schduler calendar is starting from 07:00 am.

public looks good:-

public page

scheduler

scheduler

@iamareebjamal
Copy link
Member

Thanks @sachinchauhan2889

Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@iamareebjamal iamareebjamal merged commit 9191f2d into fossasia:development Dec 31, 2020
@maze-runnar maze-runnar deleted the min-time branch December 31, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule: Calendar View Errors
4 participants