-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set min time in calendar #5997
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/a7ewywl98 |
Codecov Report
@@ Coverage Diff @@
## development #5997 +/- ##
===============================================
- Coverage 23.47% 22.97% -0.51%
===============================================
Files 511 522 +11
Lines 5466 5694 +228
Branches 67 110 +43
===============================================
+ Hits 1283 1308 +25
- Misses 4166 4357 +191
- Partials 17 29 +12
Continue to review full report at Codecov.
|
app/components/schedule.ts
Outdated
this.args.sessions.map(x => { | ||
const z = String(x.startsAt.format('HH:mm:ss')); | ||
if (min_time > z) { | ||
min_time = z; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not working on string values
What does this exactly solve? Which minimum time? For the scheduler? We had defined 5 minutes previously. Do you plan a change here? Please always add screenshots to areas you work on. This makes everything easier. |
it sets min starting time in calendar based on session starting time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is working fine for public page. suppose my event start from 21 jan 00:00 am to 21 jan 23:00 pm. My first session is from 07:00 am. At public page, calendar starts from 07:00 am.
But this is problematic for organizers. At scheduler page also calendar starts from 07:00 am.
example: my sessions start from 00:00 am to 23:00 pm. I want to schedule my sessions. calendar at scheduler page starts from 00:00 am to 23:00pm. I schedule my first session at 07:00 am. Now after this calendar at scheduler show time from 07:00 am to 23:00pm. Now I can't schedule any sessions before 07:00 am as schduler calendar is starting from 07:00 am.
public looks good:-
scheduler
Thanks @sachinchauhan2889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me.
Fixes #4996
Checklist
development
branch.