Issue App crashing on Opening in Android Oreo 8.1 #1356 #1369
Conversation
After reading through some articles, I have found out that using strict policy on certain devices will cause a DiskReadViolation that may not be related to the app's code, but due to an external library or each hardware maker's specific software. By outting " .permitDiskReads()" we can avert this situation. In the comment there is a link to an article where this is explained in detail.
Codecov Report
@@ Coverage Diff @@
## development #1369 +/- ##
==============================================
Coverage 24.53% 24.53%
Complexity 757 757
==============================================
Files 237 237
Lines 8629 8629
Branches 349 349
==============================================
Hits 2117 2117
Misses 6429 6429
Partials 83 83Continue to review full report at Codecov.
|
|
Thank you for the PR. Please follow the PR template and mention the issue number in the fixes section and also list the changes performed |
|
Also, please only permit the disk reads for Oreo and above |
|
@iamareebjamal I am going to fix this and send another PR, thanks! |
…asia#1369 Ensuring that the strict mode policy for reading is disabled only for versions above Android 8 This wants to resolve fossasia#1369
|
No need for sending another PR, you can edit this one |
|
I think I did that just now! By pulling a commit it will update this PR, correct? (sorry for the noob questions..) |
| .detectAll() | ||
| .penaltyDeath(); | ||
|
|
||
| if (android.os.Build.VERSION.SDK_INT > Build.VERSION_CODES.O) { |
There was a problem hiding this comment.
This should be >=
And why fully qualified class name for Build?
There was a problem hiding this comment.
You are correct, my mistake, on it.
Fixing Code Style This wants to resolve fossasia#1356
|
Great, now please update the PR description following the template |
|
Will do! |
|
From what I read, I had to update the description to have the "resolve" keyword and check the correct checkboxes, right? |
|
To quote the PR template:
|
|
Changed! Sorry for all the inconvenience |
Fixes #1356
After reading through some articles, I have found out that using strict policy on certain devices will cause a DiskReadViolation that may not be related to the app's code, but due to an external library or each hardware maker's specific software.
By outting " .permitDiskReads()" we can avert this situation. In the comment there is a link to an article where this is explained in detail.
Checklist:
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshots for the change: