Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: grammar error in README is fixed #1406

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

AB261
Copy link
Contributor

@AB261 AB261 commented Dec 11, 2018

Fixes #1405

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes: Under project conventions in the README fixed the grammar error where it said "There is certain conventions" to "There are certain conventions"

Changed from "There is certain conventions" to "There are certain conventions"
@AB261 AB261 changed the title Fix:Grammar error in README fix:Grammar error in README Dec 11, 2018
@AB261 AB261 changed the title fix:Grammar error in README Styles:grammar error in README is fixed Dec 11, 2018
@AB261 AB261 changed the title Styles:grammar error in README is fixed chore:grammar error in README is fixed Dec 11, 2018
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #1406 into development will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1406      +/-   ##
=================================================
+ Coverage          24.45%   24.46%   +0.01%     
  Complexity           757      757              
=================================================
  Files                237      237              
  Lines               8658     8658              
  Branches             351      351              
=================================================
+ Hits                2117     2118       +1     
+ Misses              6458     6457       -1     
  Partials              83       83
Impacted Files Coverage Δ Complexity Δ
...izer/core/ticket/create/CreateTicketViewModel.java 86.27% <0%> (+1.96%) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07fac6e...0c8f3ae. Read the comment docs.

@iamareebjamal
Copy link
Member

Please follow semantic Pull Request guidelines and change the PR title with imperative message

@AB261 AB261 changed the title chore:grammar error in README is fixed docs:correct grammar mistake of README Dec 11, 2018
@AB261 AB261 changed the title docs:correct grammar mistake of README chore: grammar error in README is fixed Dec 11, 2018
@Masquerade0097 Masquerade0097 merged commit d8cab3f into fossasia:development Dec 11, 2018
@iamareebjamal
Copy link
Member

docs: correct grammatical mistake of README would have been better 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix a grammar mistake in README under Project Conventions
4 participants