Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hardcoded dimensions #1457

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

GOVINDDIXIT
Copy link
Member

@GOVINDDIXIT GOVINDDIXIT commented Jan 24, 2019

Fixes #1456

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #1457 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1457   +/-   ##
==============================================
  Coverage          24.25%   24.25%           
  Complexity           757      757           
==============================================
  Files                237      237           
  Lines               8737     8737           
  Branches             356      356           
==============================================
  Hits                2119     2119           
  Misses              6534     6534           
  Partials              84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad70b79...84493db. Read the comment docs.

@GOVINDDIXIT
Copy link
Member Author

@iamareebjamal pls review

@iamareebjamal iamareebjamal merged commit 75ba7c1 into fossasia:development Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants