-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change Share menu to Done menu option #1530
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1530 +/- ##
=================================================
+ Coverage 23.87% 24.42% +0.54%
- Complexity 757 782 +25
=================================================
Files 238 239 +1
Lines 8889 8972 +83
Branches 367 369 +2
=================================================
+ Hits 2122 2191 +69
- Misses 6683 6697 +14
Partials 84 84
Continue to review full report at Codecov.
|
You have removed the validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach a Gif.
Shouldn't there be an "Event Updated Successfully" toast/snackbar notification? |
@kush-mish There should be a toast with the success message. |
By mistake |
@Masquerade0097 please help with this here 👉 4e737fd#commitcomment-32665496 |
@iamareebjamal can't this be merged? |
Fixes #1529
Checklist
Changes
Screenshot