Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change Share menu to Done menu option #1530

Merged
merged 4 commits into from
Mar 16, 2019

Conversation

kush-mish
Copy link
Contributor

@kush-mish kush-mish commented Mar 5, 2019

Fixes #1529

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have checked for PMD and check-style issues

Changes

  • Changes the share menu item to the done menu item in the UpdateEventFragment toolbar.
  • Removes the green Done button from the bottom of the layout.

Screenshot

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1530 into development will increase coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1530      +/-   ##
=================================================
+ Coverage          23.87%   24.42%   +0.54%     
- Complexity           757      782      +25     
=================================================
  Files                238      239       +1     
  Lines               8889     8972      +83     
  Branches             367      369       +2     
=================================================
+ Hits                2122     2191      +69     
- Misses              6683     6697      +14     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...ganizer/core/event/create/UpdateEventFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ganizer/core/track/update/UpdateTrackFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ganizer/core/track/create/CreateTrackFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ay/organizer/common/di/module/ViewModelModule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...anizer/core/track/update/UpdateTrackPresenter.java
...anizer/core/track/update/UpdateTrackViewModel.java 60.78% <0%> (ø) 12% <0%> (?)
...anizer/core/track/create/CreateTrackViewModel.java 88.37% <0%> (ø) 13% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cc5f8...bdfb104. Read the comment docs.

@kush-mish kush-mish changed the title Change Share menu to Done menu option feat: Change Share menu to Done menu option Mar 6, 2019
@kush-mish kush-mish changed the title feat: Change Share menu to Done menu option chore: Change Share menu to Done menu option Mar 6, 2019
@iamareebjamal
Copy link
Member

You have removed the validation

Copy link
Member

@Masquerade0097 Masquerade0097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a Gif.

@kush-mish
Copy link
Contributor Author

kush-mish commented Mar 7, 2019

Shouldn't there be an "Event Updated Successfully" toast/snackbar notification?

@Masquerade0097
Copy link
Member

@kush-mish There should be a toast with the success message.

@Masquerade0097
Copy link
Member

By mistake

@Masquerade0097 Masquerade0097 reopened this Mar 9, 2019
@kush-mish
Copy link
Contributor Author

@Masquerade0097 please help with this here 👉 4e737fd#commitcomment-32665496

@kush-mish
Copy link
Contributor Author

@iamareebjamal can't this be merged?

@iamareebjamal iamareebjamal merged commit 8a19cef into fossasia:development Mar 16, 2019
@kush-mish kush-mish deleted the issue#1529 branch March 17, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants