-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement list of roles #1685
Conversation
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 58dad71. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 23fca5b. Here's the output:
|
|
||
@Override | ||
public void migrate(@NonNull DatabaseWrapper databaseWrapper) { | ||
Timber.d("Running migration for DB version 19"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19 can be replaced by VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a log statement
|
||
Class<?>[] recreated = new Class[] {Role.class, RoleInvite.class}; | ||
|
||
for (Class<?> recreate: recreated) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To create an array of classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the separator between items |
Done. |
@iamareebjamal This is ready to be merged. |
Fixes #1683