Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement list of roles #1685

Merged
merged 10 commits into from
Jun 12, 2019
Merged

feat: Implement list of roles #1685

merged 10 commits into from
Jun 12, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jun 1, 2019

Fixes #1683

Roles list

@ci-reporter
Copy link

ci-reporter bot commented Jun 1, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 58dad71. Here's the output:

Test Coverage

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for 58dad71
Test Coverage

Failed build for 8584b5b
Run Tests

Failed build for 07b408e
Run Tests

Failed build for 07b408e
Run Tests

Failed build for 92b406f
Test Coverage

Failed build for 23fca5b
Run Tests


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ci-reporter
Copy link

ci-reporter bot commented Jun 1, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 23fca5b. Here's the output:

Run Tests

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@fossasia fossasia deleted a comment Jun 1, 2019
@fossasia fossasia deleted a comment Jun 1, 2019
@fossasia fossasia deleted a comment Jun 1, 2019
@fossasia fossasia deleted a comment Jun 1, 2019
@fossasia fossasia deleted a comment Jun 2, 2019
@ShridharGoel ShridharGoel changed the title [WIP] feat: Implement list of roles feat: Implement list of roles Jun 3, 2019
@auto-label auto-label bot added the feature label Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment Jun 3, 2019
@fossasia fossasia deleted a comment from liveHarshit Jun 3, 2019
@fossasia fossasia deleted a comment from ShridharGoel Jun 3, 2019
@fossasia fossasia deleted a comment Jun 4, 2019
@fossasia fossasia deleted a comment Jun 5, 2019

@Override
public void migrate(@NonNull DatabaseWrapper databaseWrapper) {
Timber.d("Running migration for DB version 19");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 can be replaced by VERSION

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a log statement


Class<?>[] recreated = new Class[] {Role.class, RoleInvite.class};

for (Class<?> recreate: recreated) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To create an array of classes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liveHarshit
liveHarshit previously approved these changes Jun 7, 2019
@iamareebjamal
Copy link
Member

Remove the separator between items

@ShridharGoel
Copy link
Member Author

Remove the separator between items

Done.

iamareebjamal
iamareebjamal previously approved these changes Jun 9, 2019
@ShridharGoel
Copy link
Member Author

@iamareebjamal This is ready to be merged.

@iamareebjamal iamareebjamal merged commit e3319fc into fossasia:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list of accepted/invited roles
3 participants