Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add 'Use another URL' button for base URL #1699

Merged
merged 5 commits into from
Jun 13, 2019
Merged

chore: Add 'Use another URL' button for base URL #1699

merged 5 commits into from
Jun 13, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jun 7, 2019

Fixes #1698

GIF for the change:

Use another URL

@auto-label auto-label bot added the chore label Jun 7, 2019
@ShridharGoel ShridharGoel changed the title chore: Add option to use another URL in Get Started chore: Add option to use another base URL Jun 7, 2019
@ShridharGoel ShridharGoel changed the title chore: Add option to use another base URL chore: Add 'Use another URL' button for base URL Jun 7, 2019
@fossasia fossasia deleted a comment Jun 7, 2019
@fossasia fossasia deleted a comment Jun 12, 2019
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we talk about the app here, we talk about the app that we put on the app store usually. For the appstore we always want to use eventyay.com. Please change as follows:

  1. Use default URL -> Custom Server (you can put in here the open-event-api server manually when you work on it)
  2. open-event-api... -> delete it. Don't show it! And use eventyay.com.

@fossasia fossasia deleted a comment Jun 12, 2019
@ShridharGoel
Copy link
Member Author

@mariobehling The production app always uses api.eventyay.com. These settings are only for the debug app.

  1. open-event-api... -> delete it. Don't show it! And use eventyay.com.

Yes, this will done in #1700. I'll open a PR by tonight.

@fossasia fossasia deleted a comment Jun 12, 2019
@fossasia fossasia deleted a comment Jun 13, 2019
@iamareebjamal iamareebjamal merged commit 43f025b into fossasia:development Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Use another URL' option instead of current checkbox system for base URL
3 participants