-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add event name and time in dashboard #1858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShridharGoel
changed the title
[WIP} chore: Add event name and time in dashboard
[WIP] chore: Add event name and time in dashboard
Aug 4, 2019
@iamareebjamal Please check the screenshot. |
@iamareebjamal Please see the screenshot and tell if it's fine. |
User will have no idea what the switch is for. UI needs to improve |
Show event name instead of Event Dashboard |
ShridharGoel
force-pushed
the
issue1856
branch
from
August 10, 2019 10:01
e401e88
to
e40fa72
Compare
@iamareebjamal Is this fine? |
Add date in the subtitle of toolbar |
ShridharGoel
force-pushed
the
issue1856
branch
from
August 11, 2019 11:19
411dbdb
to
babf0ec
Compare
@iamareebjamal Done |
ShridharGoel
changed the title
[WIP] chore: Add event name and time in dashboard
chore: Add event name and time in dashboard
Aug 11, 2019
Decrease the subtitle size please. It's too large |
ShridharGoel
force-pushed
the
issue1856
branch
from
August 11, 2019 12:06
0975394
to
6eced7c
Compare
iamareebjamal
approved these changes
Aug 11, 2019
iamareebjamal
changed the title
chore: Add event name and time in dashboard
feat: Add event name and time in dashboard
Aug 11, 2019
iamareebjamal
changed the title
feat: Add event name and time in dashboard
feat(ui): Add event name and time in dashboard
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1856
Screenshot for the change: