Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add event name and time in dashboard #1858

Merged
merged 3 commits into from
Aug 11, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Aug 4, 2019

Fixes #1856

Screenshot for the change:
Event date and time in dashboard

@ShridharGoel ShridharGoel changed the title [WIP} chore: Add event name and time in dashboard [WIP] chore: Add event name and time in dashboard Aug 4, 2019
@ShridharGoel
Copy link
Member Author

@iamareebjamal Please check the screenshot.

@fossasia fossasia deleted a comment from ci-reporter bot Aug 5, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Aug 5, 2019
@ShridharGoel
Copy link
Member Author

@iamareebjamal Please see the screenshot and tell if it's fine.

@iamareebjamal
Copy link
Member

User will have no idea what the switch is for. UI needs to improve

@ShridharGoel
Copy link
Member Author

What about this?

Dashboard

@fossasia fossasia deleted a comment Aug 6, 2019
@fossasia fossasia deleted a comment Aug 6, 2019
@fossasia fossasia deleted a comment Aug 6, 2019
@iamareebjamal
Copy link
Member

Show event name instead of Event Dashboard

@ShridharGoel
Copy link
Member Author

Event dashboard

@ShridharGoel
Copy link
Member Author

@iamareebjamal Is this fine?

@fossasia fossasia deleted a comment from ci-reporter bot Aug 10, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Aug 10, 2019
@iamareebjamal
Copy link
Member

Add date in the subtitle of toolbar

@ShridharGoel
Copy link
Member Author

@iamareebjamal Done

Event Dashboard

@ShridharGoel ShridharGoel changed the title [WIP] chore: Add event name and time in dashboard chore: Add event name and time in dashboard Aug 11, 2019
@auto-label auto-label bot added the chore label Aug 11, 2019
@iamareebjamal
Copy link
Member

Decrease the subtitle size please. It's too large

@ShridharGoel
Copy link
Member Author

Is this fine or should the size be reduced further?

Event Dashboard

@iamareebjamal iamareebjamal changed the title chore: Add event name and time in dashboard feat: Add event name and time in dashboard Aug 11, 2019
@auto-label auto-label bot removed the chore label Aug 11, 2019
@auto-label auto-label bot added the feature label Aug 11, 2019
@iamareebjamal iamareebjamal changed the title feat: Add event name and time in dashboard feat(ui): Add event name and time in dashboard Aug 11, 2019
@iamareebjamal iamareebjamal merged commit fe51d5d into fossasia:development Aug 11, 2019
@ShridharGoel ShridharGoel deleted the issue1856 branch August 11, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event name and time in dashboard
2 participants