test:Add Integration tests for account delete functions #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 26, 2019
mrsaicharan1
force-pushed
the
integration-tests
branch
from
2c0ac08 to
9628668
Compare
houndci-bot
reviewed
Jun 27, 2019
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
mrsaicharan1
changed the title
mrsaicharan1
force-pushed
the
integration-tests
branch
from
9628668 to
7385e54
Compare
houndci-bot
reviewed
Jun 27, 2019
mrsaicharan1
force-pushed
the
integration-tests
branch
from
7385e54 to
a0be7c7
Compare
mrsaicharan1
force-pushed
the
integration-tests
branch
3 times, most recently
from
46d3ab8 to
66c065e
Compare
Codecov Report
@@ Coverage Diff @@
## development #6108 +/- ##
===============================================
+ Coverage 66.16% 66.45% +0.29%
===============================================
Files 285 286 +1
Lines 14212 14242 +30
===============================================
+ Hits 9403 9465 +62
+ Misses 4809 4777 -32
Continue to review full report at Codecov.
|
add test for user email modified when deleted Add tests for user delete restore Hound Issues Added exception handling test
mrsaicharan1
force-pushed
the
integration-tests
branch
from
66c065e to
ecab241
Compare
|
@iamareebjamal @uds5501 @shreyanshdwivedi Please review! |
| save_to_db(user1) | ||
| user2 = create_user(email="test_user@gmail.com.deleted", password="testpass") | ||
| save_to_db(user2) | ||
| self.assertRaises(ForbiddenException, modify_email_for_user_to_be_restored, user2) |
There was a problem hiding this comment.
The tests LGTM 👍
@mrsaicharan1 just a query - Is the user2 passed to the function modify_email_for_user_to_be_restored by this line?
There was a problem hiding this comment.
@shreyanshdwivedi yes, that's how assertRaises works!
|
@iamareebjamal @CosmicCoder96 Please review. |
shreyanshdwivedi
approved these changes
Jun 27, 2019
iamareebjamal
approved these changes
Jun 27, 2019
|
@niranjan94 @CosmicCoder96 PLease have a look |
iamareebjamal
pushed a commit
to iamareebjamal/open-event-server
that referenced
this pull request
Aug 2, 2019
add test for user email modified when deleted Add tests for user delete restore Hound Issues Added exception handling test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6107
Part of #5320
Short description of what this resolves:
Increases test coverage by adding integrations tests for user delete helper functions
Changes proposed in this pull request:
Checklist
developmentbranch.