Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returns queried feedback only #6150

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

shreyanshdwivedi
Copy link
Member

Fixes #6149

Short description of what this resolves:

feedback query always returns all the feedbacks

Changes proposed in this pull request:

  • returns feedback according to query params i.e. user_id or session_id

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 7, 2019
@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #6150 into development will decrease coverage by 0.02%.
The diff coverage is 12.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6150      +/-   ##
===============================================
- Coverage        66.41%   66.38%   -0.03%     
===============================================
  Files              286      286              
  Lines            14380    14387       +7     
===============================================
+ Hits              9550     9551       +1     
- Misses            4830     4836       +6
Impacted Files Coverage Δ
app/api/schema/users.py 100% <ø> (ø) ⬆️
app/api/feedbacks.py 53.42% <12.5%> (-4.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a615f...4de22a3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit dc9c7c7 into fossasia:development Jul 7, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the feedbackQuery branch July 7, 2019 14:52
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedback query always returns all the feedbacks
2 participants