Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes attendee ticket attachments & email #6156

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 8, 2019

Fixes #6155

Short description of what this resolves:

Changes the storage path key to fix attachments & email issue.

Changes proposed in this pull request:

  • Storage Key modification

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 8, 2019
@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi @iamareebjamal This should fix the emails & FileNotFoundError

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #6156 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6156   +/-   ##
============================================
  Coverage        66.29%   66.29%           
============================================
  Files              286      286           
  Lines            14415    14415           
============================================
  Hits              9557     9557           
  Misses            4858     4858
Impacted Files Coverage Δ
app/api/orders.py 31.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f9fb8...59cce91. Read the comment docs.

Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on local now.

@niranjan94 niranjan94 merged commit 22830f0 into fossasia:development Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket attachments for attendee emails are not working.
4 participants