Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Helm chart for open event #6904

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

MikeLing
Copy link
Contributor

Fixes #

Short description of what this resolves:

This PR is gonna to add helm chart for open even server side and frontend side.

Changes proposed in this pull request:

Add Helm charts

Checklist

  • [+] I have read the Contribution & Best practices Guide and my PR follows them.
  • [+] My branch is up-to-date with the Upstream development branch.
  • [+] The unit tests pass locally with my changes
  • [+] I have added tests that prove my fix is effective or that my feature works
  • [+] I have added necessary documentation (if appropriate)
  • [+] All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #6904 into development will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6904      +/-   ##
===============================================
+ Coverage        66.34%   66.40%   +0.06%     
===============================================
  Files              308      313       +5     
  Lines            15327    15358      +31     
===============================================
+ Hits             10168    10198      +30     
- Misses            5159     5160       +1     
Impacted Files Coverage Δ
app/graphql/types/settings/schema.py 100.00% <0.00%> (ø)
app/graphql/views.py 100.00% <0.00%> (ø)
tests/all/unit/graphql/utils/test_fields.py 100.00% <0.00%> (ø)
app/graphql/utils/fields.py 100.00% <0.00%> (ø)
app/graphql/schema.py 87.50% <0.00%> (ø)
app/instance.py 87.50% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd744b6...c8b9334. Read the comment docs.

@iamareebjamal iamareebjamal self-requested a review March 29, 2020 15:51
@iamareebjamal
Copy link
Member

iamareebjamal commented Mar 29, 2020

Thanks a lot for the addition. We really needed this. There are some modifications required like the open-event-frontend image does not need to be rebuilt, eventyay/open-event-frontend:latest can be used with environment variables.
This is what I found by just glancing at it. I'll give a more thorough review as soon as I get some time. Thanks

@MikeLing
Copy link
Contributor Author

Thanks a lot for the addition. We really needed this. There are some modifications required like the open-event-frontend image does not need to be rebuilt, eventyay/open-event-frontend:latest can be used with environment variables.
This is what I found by just glancing at it. I'll give a more thorough review as soon as I get some time. Thanks

Ah, ok I got it ;)

@iamareebjamal iamareebjamal changed the title Add Helm chart for open event chore: Add Helm chart for open event Apr 14, 2020
@auto-label auto-label bot added the chore label Apr 14, 2020
@iamareebjamal iamareebjamal merged commit b2788a8 into fossasia:development Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants