fix: Make event-invoices endpoint admin only #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #7096 +/- ##
===============================================
- Coverage 62.01% 62.00% -0.01%
===============================================
Files 262 262
Lines 12995 13000 +5
===============================================
+ Hits 8059 8061 +2
- Misses 4936 4939 +3
Continue to review full report at Codecov.
|
iamareebjamal
requested changes
Jun 30, 2020
|
@iamareebjamal Please review |
iamareebjamal
requested changes
Jun 30, 2020
app/api/event_invoices.py
Outdated
| @@ -39,6 +40,10 @@ def query(self, view_kwargs): | |||
| :param view_kwargs: | |||
| :return: | |||
| """ | |||
| user = current_user | |||
| if not user.is_admin and not user.is_super_admin: | |||
| @@ -61,8 +61,9 @@ def is_organizer(view, view_args, view_kwargs, *args, **kwargs): | |||
| if user.is_staff: | |||
| return view(*view_args, **view_kwargs) | |||
|
|
|||
| if user.is_owner(kwargs['event_id']) or user.is_organizer(kwargs['event_id']): | |||
| return view(*view_args, **view_kwargs) | |||
| if kwargs.get('event_id'): | |||
There was a problem hiding this comment.
This can be extracted in a variable and reused
|
Complexity increasing per file
==============================
- app/api/event_invoices.py 1
See the complete overview on Codacy |
iamareebjamal
approved these changes
Jun 30, 2020
|
Ignore remaining deepsource issues. We should only fix code related to issue. Don't revert the already made changes though |
Haider8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7063
Short description of what this resolves:
Currently
/event-invoicesendpoint requires theevent_idparam in url or expects the user to be admin, which is not the case for this endpoint.Changes proposed in this pull request:
Remove decorators
is_organizerandis_admin.Checklist
developmentbranch.