Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow orgnizers to unlock sessions and add tests #7186

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 4, 2020

Fixes #7185

owner = new_user
creator = user
session = SessionSubFactory(creator_id=creator.id, **kwargs)
role, _ = get_or_create(Role, name='owner', title_name='Owner')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@auto-label auto-label bot added the fix label Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #7186 into development will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7186      +/-   ##
===============================================
- Coverage        62.89%   62.89%   -0.01%     
===============================================
  Files              259      259              
  Lines            12996    12989       -7     
===============================================
- Hits              8174     8169       -5     
+ Misses            4822     4820       -2     
Impacted Files Coverage Δ
app/api/sessions.py 57.76% <100.00%> (+1.05%) ⬆️
app/api/helpers/db.py 96.72% <0.00%> (-1.47%) ⬇️
app/api/helpers/files.py 73.71% <0.00%> (-1.29%) ⬇️
app/models/order.py 91.54% <0.00%> (+0.75%) ⬆️
app/models/event_invoice.py 95.23% <0.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263419...6fa1ebf. Read the comment docs.

@iamareebjamal iamareebjamal merged commit dfcd530 into development Aug 4, 2020
@iamareebjamal iamareebjamal deleted the session-lock branch August 4, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session unlock not possible for organizers and admins
2 participants