Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add public payment gateway key in settings #7197

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

divs4debu
Copy link
Contributor

@divs4debu divs4debu commented Aug 8, 2020

Fixes #7187

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.



def test_payment_gateway(db, client):
response = client.get('/v1/settings')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@auto-label auto-label bot added the fix label Aug 8, 2020
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #7197 into development will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7197      +/-   ##
===============================================
+ Coverage        62.87%   63.02%   +0.14%     
===============================================
  Files              259      259              
  Lines            12992    13013      +21     
===============================================
+ Hits              8169     8201      +32     
+ Misses            4823     4812      -11     
Impacted Files Coverage Δ
app/api/schema/settings.py 100.00% <100.00%> (ø)
app/api/helpers/mail.py 25.64% <0.00%> (-1.72%) ⬇️
app/api/helpers/permission_manager.py 58.39% <0.00%> (+0.69%) ⬆️
app/api/sessions.py 58.75% <0.00%> (+2.04%) ⬆️
app/models/setting.py 93.96% <0.00%> (+7.75%) ⬆️
app/api/settings.py 72.72% <0.00%> (+11.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b605aa...08e8468. Read the comment docs.

@iamareebjamal iamareebjamal merged commit f609453 into fossasia:development Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe publishable key should be accessible to non-admin user
3 participants