-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow refund_policy to be none #7254
fix: allow refund_policy to be none #7254
Conversation
refund_policy = db.Column( | ||
db.String, default='All sales are final. No refunds shall be issued in any case.' | ||
) | ||
refund_policy = db.Column(db.String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a migration for past events, right?
Codecov Report
@@ Coverage Diff @@
## development #7254 +/- ##
============================================
Coverage 63.55% 63.55%
============================================
Files 259 259
Lines 13034 13034
============================================
Hits 8284 8284
Misses 4750 4750
Continue to review full report at Codecov.
|
Yes, we need to set refund policy to null for previous events. |
Thinking about it now, if some user changed their refund policy using the API, making it null will lead to data loss. So, wait for Mario to tell what should be done |
I think we can apply migration only to events having the default |
In regards to events we should delete the policy. There was not any organizer who edited the policy, we just introduced it a few hours ago. Is that easy to do? I dont think we need migrations. |
We didn't add it a few hours ago. We used it as default refund policy for all events in the backend since a long time ago |
886763e
to
9fd4b64
Compare
This pull request introduces 2 alerts when merging bd63158 into 97f3497 - view on LGTM.com new alerts:
|
for fossasia/open-event-frontend#5036