Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sales time of the ticket is passed, don't show event #7439

Merged
merged 1 commit into from
Nov 12, 2020
Merged

fix: sales time of the ticket is passed, don't show event #7439

merged 1 commit into from
Nov 12, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 12, 2020

… on the start page

Fixes fossasia/open-event-frontend#5110

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@iamareebjamal iamareebjamal changed the title fix: sales time of the ticket is passed, don't show event on front page fix: sales time of the ticket is passed, don't show event Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #7439 (9ab35c6) into development (ef592f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7439   +/-   ##
============================================
  Coverage        65.28%   65.28%           
============================================
  Files              265      265           
  Lines            13220    13220           
============================================
  Hits              8631     8631           
  Misses            4589     4589           
Impacted Files Coverage Δ
app/api/events.py 38.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef592f0...9ab35c6. Read the comment docs.

@iamareebjamal iamareebjamal merged commit bf35477 into fossasia:development Nov 12, 2020
@maze-runnar maze-runnar deleted the patch-6 branch November 12, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontpage: Limit display of events based on the public ticket availability
2 participants