Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ticket sold out event page restriction #7470

Merged
merged 2 commits into from
Dec 13, 2020
Merged

fix: ticket sold out event page restriction #7470

merged 2 commits into from
Dec 13, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes fossasia/open-event-frontend#5110

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #7470 (f8a0e52) into development (c5bf371) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7470   +/-   ##
============================================
  Coverage        66.25%   66.25%           
============================================
  Files              267      267           
  Lines            13233    13233           
============================================
  Hits              8767     8767           
  Misses            4466     4466           
Impacted Files Coverage Δ
app/api/events.py 52.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bf371...f8a0e52. Read the comment docs.

Order.status == 'placed',
Order.status == 'completed')
).count() < Ticket.quantity
)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test

@iamareebjamal iamareebjamal merged commit fb37a8b into fossasia:development Dec 13, 2020
@maze-runnar maze-runnar deleted the ticket-soldout branch December 27, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontpage: Limit display of events based on the public ticket availability
2 participants