Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Not Connected' toast message repeatedly keeps popping up in Dust Sensor #2000

Closed
abhishekbisht1429 opened this issue Nov 9, 2019 · 8 comments · Fixed by #2002
Closed

'Not Connected' toast message repeatedly keeps popping up in Dust Sensor #2000

abhishekbisht1429 opened this issue Nov 9, 2019 · 8 comments · Fixed by #2002
Assignees

Comments

@abhishekbisht1429
Copy link
Contributor

Actual Behaviour

When dust sensor is not connected, the not connected toast message keeps popping up repeatedly.

Expected Behaviour

The not connected message must not keep flashing before the screen just like it is in other sensors where the message is displayed only once

Steps to reproduce it

  • Do not connected the USB device and then open the Dust Sensor

LogCat for the issue

N/A

Screenshots of the issue

toast_issue4

Would you like to work on the issue?

Yes

@shreyansjain012
Copy link

Hi. Is this issue assigned to someone else? I would live to work on it

@adityastic
Copy link
Collaborator

@shreyansjain012 we might need input from @reckoner1429 atm

@abhishekbisht1429
Copy link
Contributor Author

@shreyansjain012 and @adityastic , I also want this issue to be assigned to me, however I have not received any word from the repository maintainers.
PS - This is my first attempt at open source contributions so i am not very well aware about how long will i have to wait to receive a word from the maintainers

@neel1998
Copy link
Member

@reckoner1429 since you have raised the issue and also mentioned you would like to work on it there is no need for you to wait for the maintainers to assign the issue to you. You can start working on it and make the PR. Please refer to the readme for contributors and follow the best practices . Cheers.

@shreyansjain012
Copy link

@reckoner1429 @adityastic I am new to open source I think I have the code ready which is working fine but I don't know how to proceed from here? Should I wait for someone to assign it or just submit a pull request?

@neel1998
Copy link
Member

neel1998 commented Nov 12, 2019

@shreyansjain012 it's great that you have solved this issue but since the author of the issue already mention that he would like to work on it is not good practice to file a PR until the author says he is not gonna work on it anymore. In this case if @reckoner1429 is not going to work on this issue anymore you can file a PR

@shreyansjain012
Copy link

@neel1998 Okay. Thanks.

@abhishekbisht1429
Copy link
Contributor Author

@neel1998 Thanks a lot for the directions! I am now working on this issue.

abhishekbisht1429 added a commit to abhishekbisht1429/pslab-android that referenced this issue Nov 12, 2019
neel1998 added a commit that referenced this issue Nov 12, 2019
Fixes #2000 Fixed the repeated display of 'Not Connected' Toast messa…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants