-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Not Connected' toast message repeatedly keeps popping up in Dust Sensor #2000
Comments
Hi. Is this issue assigned to someone else? I would live to work on it |
@shreyansjain012 we might need input from @reckoner1429 atm |
@shreyansjain012 and @adityastic , I also want this issue to be assigned to me, however I have not received any word from the repository maintainers. |
@reckoner1429 since you have raised the issue and also mentioned you would like to work on it there is no need for you to wait for the maintainers to assign the issue to you. You can start working on it and make the PR. Please refer to the readme for contributors and follow the best practices . Cheers. |
@reckoner1429 @adityastic I am new to open source I think I have the code ready which is working fine but I don't know how to proceed from here? Should I wait for someone to assign it or just submit a pull request? |
@shreyansjain012 it's great that you have solved this issue but since the author of the issue already mention that he would like to work on it is not good practice to file a PR until the author says he is not gonna work on it anymore. In this case if @reckoner1429 is not going to work on this issue anymore you can file a PR |
@neel1998 Okay. Thanks. |
@neel1998 Thanks a lot for the directions! I am now working on this issue. |
…st message in DustSensor
Fixes #2000 Fixed the repeated display of 'Not Connected' Toast messa…
Actual Behaviour
When dust sensor is not connected, the not connected toast message keeps popping up repeatedly.
Expected Behaviour
The not connected message must not keep flashing before the screen just like it is in other sensors where the message is displayed only once
Steps to reproduce it
LogCat for the issue
Screenshots of the issue
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: