Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimeter: Layout looks weird on tablet devices #2118

Closed
marcnause opened this issue Jun 10, 2020 · 3 comments · Fixed by #2129
Closed

Multimeter: Layout looks weird on tablet devices #2118

marcnause opened this issue Jun 10, 2020 · 3 comments · Fixed by #2129
Labels

Comments

@marcnause
Copy link
Contributor

Actual Behaviour

The multimeter looks weird on tablet devices, the measured value is partly hidden.

Expected Behaviour

The layout should look more pleasing (larger knob or a margin around the whole multimeter) and the value should be completely visible.

Steps to reproduce it

  1. Start app on tablet device
  2. Select multimeter

Screenshots of the issue

Screenshot_20200610-224910

Would you like to work on the issue?

Maybe..

@xanmolx
Copy link

xanmolx commented Jun 29, 2020

I am unable to reproduce the issue.
Screenshot_1593444674

This is the screenshot on a tablet emulator device
Device:- Pixel C
Android Version:- 10

@marcnause
Copy link
Contributor Author

My device:

Device: Lenovo Yoga Smart Tab
Android Version: 9

@Girish-Bharadwaj
Copy link
Contributor

Hey I would like to solve this issue and try my best

riturajjain2000 added a commit to riturajjain2000/pslab-android that referenced this issue Oct 5, 2020
Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen
riturajjain2000 added a commit to riturajjain2000/pslab-android that referenced this issue Oct 5, 2020
Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen
@riturajjain2000 riturajjain2000 mentioned this issue Oct 5, 2020
5 tasks
CloudyPadmal pushed a commit that referenced this issue Oct 12, 2020
* This commit Fixes #2119 #2118

Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen

* This commit Fixes #2119 #2118

Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen

* Made Changes as asked

Now the Multimeter ,  Wavegenerator and Powersource Activities  will remain only in portrait mode in normal sized phones and will have both portrait and landscape modes in Tablets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants