Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDrawable() is deprecated and needs to be replaced #2206

Closed
Abhinavtdk opened this issue Mar 20, 2021 · 8 comments
Closed

getDrawable() is deprecated and needs to be replaced #2206

Abhinavtdk opened this issue Mar 20, 2021 · 8 comments
Labels
Codeheat hacktoberfest

Comments

@Abhinavtdk
Copy link
Contributor

Actual Behaviour

getDrawable( int ) is deprecated and is used in many places in the project

Expected Behaviour

getDrawable() needs to be replaced, we can use ResourcesCompat.getDrawable()

Would you like to work on the issue?

Yes
Abhinavtdk added a commit to Abhinavtdk/pslab-android that referenced this issue Mar 20, 2021
@Abhinavtdk
Fixes fossasia#2206: replaced getDrawable()
c2b86d7
@Abhinavtdk Abhinavtdk mentioned this issue Mar 20, 2021
Closed
5 tasks
@Glock123
Copy link

Is this issue closed?

@Abhinavtdk
Copy link
Contributor Author

Is this issue closed?

I made a pr #2207 , it has to be approved

@Aditya8840
Copy link

is this open ?

@kartikaysharma01
Copy link
Member

Hi @Aditya8840, This issue is not a priority right now. Please have a look at some other issues. You can refer to the prior discussion here. Thanks.

@sakshampruthi
Copy link
Contributor

Is this issue still valid and open ?

@CloudyPadmal
Copy link
Collaborator

@sakshampruthi yes

@sakshampruthi
Copy link
Contributor

Great, I'd like to work on this issue

sakshampruthi pushed a commit to sakshampruthi/pslab-android that referenced this issue Oct 15, 2021
Fixes fossasia#2206 getDrawable replaced with ResourcesCompat.getDraw…
33ef73d 
…able()
@sakshampruthi sakshampruthi mentioned this issue Oct 15, 2021
Merged
5 tasks
@Prakhar-Agarwal-byte
Copy link

I am working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Codeheat hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced getDrawable() with ResourcesCompat.getDrawable() Abhinavtdk/pslab-android
8 participants
@mariobehling @CloudyPadmal @Prakhar-Agarwal-byte @sakshampruthi @Glock123 @Abhinavtdk @kartikaysharma01 @Aditya8840