feat: MQ135 Gas sensor added #1913
Conversation
app/src/main/res/values/strings.xml
Outdated
| @@ -849,6 +849,11 @@ | |||
|
|
|||
| <string name="no_baro_sensor">Device does not have a barometer</string> | |||
|
|
|||
| <string name="gas_sensor">Gas Sensor</string> | |||
| <string name="gas_sensor_description">Detects amounts of gases in air</string> | |||
There was a problem hiding this comment.
Refer to the datasheet of that sensor and correct this to that specific gas.
There was a problem hiding this comment.
Air Quality Sensor (MQ135) Description: Air quality sensor for detecting a wide range of gases, including NH3, NOx, alcohol, benzene, smoke and CO2
| android:id="@+id/gas_sensor" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="@dimen/speedometer_height" | ||
| android:padding="15dp" |
There was a problem hiding this comment.
Double check for hard coded values
| @@ -161,7 +166,8 @@ protected Void doInBackground(Void... params) { | |||
| R.string.compass_description, | |||
| R.string.gyroscope_description, | |||
| R.string.thermometer_desc, | |||
| R.string.robotic_arm_descriptoin | |||
There was a problem hiding this comment.
Correct this one's spelling along with this
There was a problem hiding this comment.
Sorry for such blunders!. I type fast and then such mistakes get out of my attention. 😂
|
@CloudyPadmal yes I am doing it... making fixes is a while |
|
@CloudyPadmal done. We can ignore Codacy for now, since most of it will be solved once logging is added to gas sensor |
Fixes #1912
Changes:Support for MQ135 added
Steps :
Screenshot/s for the changes:
https://drive.google.com/file/d/1-KxOaqE_Y5EYquMkebYpBOEc0d7GAdLS/view?usp=sharing
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
mq135.zip
@CloudyPadmal @mariobehling @cweitat have a look. For now i haven't added the logging, because that would have made this PR too huge. I have also asked @ho-dor if he can help me with svg logo for the gas sensor. The basic functionality is working fine as can be seen in the video