Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Httphandler class #1927

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

neel1998
Copy link
Member

@neel1998 neel1998 commented Aug 13, 2019

Fixes #1926

Changes: added http handler class

Screenshot/s for the changes:
N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
N/A

@neel1998
Copy link
Member Author

Current Architecture:
currentArchitecture

New Architecture:
newArchitecture

@CloudyPadmal as shown in the above diagram we can add a new WIFI pathway to existing architecture. I have made two new functions commonRead() and commoWrite() in PacketHandler class... This will be the only point where the two architectures will diverge. I think this architecture is quite neat, and since we are not making any changes in the ScienceLab class we won't require to change a hell lot of code for wifi communication, which would also reduce the redundancy. This is still WIP. But kindly share your views. Thanks

@CloudyPadmal
Copy link
Collaborator

Yes this is the architecture proposed. Before going any further, better check if it works as intended with everything integrated (both ESP and USB).

@neel1998
Copy link
Member Author

@CloudyPadmal yes. I have already tested the new architecture for USB path and it is working as expected. So that's a good sign.

@CloudyPadmal CloudyPadmal added the In Progress Developer is working on the problem label Aug 15, 2019
@CloudyPadmal CloudyPadmal changed the title [WIP]feat: add Httphandler class feat: add Httphandler class Aug 15, 2019
@CloudyPadmal
Copy link
Collaborator

Let's use labels instead of change of titles

@neel1998
Copy link
Member Author

@CloudyPadmal I have tested the wifi path on a dummy server. The following path in the architecture to communicate over wifi was able to make get/post request to a server,

ESPFragment -> Initial Connection -> HttpAsyncTask -> HttpHandler -> HttpCallback

I think we can merge this basic architecture and then develop further on top of it.

@neel1998 neel1998 added Feature New addition to the existing app and removed In Progress Developer is working on the problem labels Aug 16, 2019
@CloudyPadmal CloudyPadmal merged commit 492df13 into fossasia:development Aug 19, 2019
@neel1998 neel1998 deleted the http_handler branch August 27, 2019 13:57
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New addition to the existing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTPHandler to communicate with ESP
2 participants